Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1183022pxb; Fri, 13 Nov 2020 06:24:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjoijao9tC4oxUQzTdrs1QQ1EN5eUdmsahspA9k3Qj69JUzr3XJOP4D0d5NQjXS0KX9+tw X-Received: by 2002:a50:d2d3:: with SMTP id q19mr2775582edg.173.1605277467657; Fri, 13 Nov 2020 06:24:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605277467; cv=none; d=google.com; s=arc-20160816; b=W5nQfzRd8tTp9e/hE2+Q0z1RFBXUcsMsLlNL8vvd3DhL4DAgH52Zq5DTNx1Yd1tk5l t2duqE+O7jdytoNFEElqKvtYBYc9RqIj4TfwEwIaCOTEv8B4Q21BuC/uCSWKK6we8xqK g+w8+0kyifbRRMNzFCewv4ZVgPpE/jQIbEpLsWM8wbKMYlo6+HiSsai5UJoiFYM6XLGu CPSCHgBz0vjlfCLC7iFXKjbjKq0aBBF2SdyAmeO6S/pn2icNyVvOKnk9g4+8aPBXEJMC 3L5YcRA5/BCoBCDakm1zqD7iqEVXcBy0tJHNcM661CK9MQCh3WwbTT8ak/cxwSzAvhmO Kncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HwbftJdZrw2PzlvsGMxdRyHB1b2SUBCJL8ZV2oz04rE=; b=z18w7gDaZMouyQgy/b07VqWkyzZmqnt7cfjvogYTYfAYr8stRnnwqUmKVjL4iiOQUe SOQx7d6NVsJvgJALHtk9TPvBKARC/2sQ/1wo6c6WV/bw7SWPv6KirnxC1O+xFVOPyd7G 8gdPaM+mJkLgs2WV0HIkPm6YO5+wzWifcv4ZYSoTrqgAMZgClTQQohXX80727ViPFicU JcGjMwiclYLF8WAp03YwrMTzLUR5z9kgBQFO202uKsoGu6I1CI9Igjj8+S/KnGphdKeY SXk/cM/T5auT8BPkaCq7kerRhFBeDuLDQSR0/Llj+PV6TvKIgab+i/A8q26d9td1PYqQ PhCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ml11si6342726ejb.697.2020.11.13.06.24.02; Fri, 13 Nov 2020 06:24:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbgKMOUB (ORCPT + 99 others); Fri, 13 Nov 2020 09:20:01 -0500 Received: from foss.arm.com ([217.140.110.172]:38996 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbgKMOUB (ORCPT ); Fri, 13 Nov 2020 09:20:01 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC0CF142F; Fri, 13 Nov 2020 06:20:00 -0800 (PST) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2BBBB3F6CF; Fri, 13 Nov 2020 06:20:00 -0800 (PST) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, Qinglang Miao Cc: Sudeep Holla , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware: arm_scmi: fix missing destroy_workqueue() Date: Fri, 13 Nov 2020 14:19:50 +0000 Message-Id: <160527711123.401015.10044003512476618871.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201110074221.41235-1-miaoqinglang@huawei.com> References: <20201110074221.41235-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Nov 2020 15:42:21 +0800, Qinglang Miao wrote: > destroy_workqueue seems necessary before return from > scmi_notification_init in the error handling case when > fails to do devm_kcalloc(). Fix this by simply moving > devm_kcalloc to the front. Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Fix missing destroy_workqueue() https://git.kernel.org/sudeep.holla/c/6bbdb46c4b -- Regards, Sudeep