Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113135427.GA167783@rlk>
In-Reply-To: <20201113135427.GA167783@rlk>
From:   Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date:   Fri, 13 Nov 2020 16:14:28 +0100
Message-ID: <CAM9Jb+iB0pbhhh=EwbG0TD2C=2-fQhiW9dUf03gSmOsjNnQ-8g@mail.gmail.com>
Subject: Re: [PATCH] mm/shmem.c: make shmem_mapping() inline
To:     Hui Su <sh_def@163.com>
Cc:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> inline the shmem_mapping(), and use shmem_mapping()
> instead of 'inode->i_mapping->a_ops == &shmem_aops'
> in shmem_evict_inode().
>
> Signed-off-by: Hui Su <sh_def@163.com>
> ---
>  include/linux/shmem_fs.h | 2 +-
>  mm/shmem.c               | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h
> index a5a5d1d4d7b1..154a16fe7fd5 100644
> --- a/include/linux/shmem_fs.h
> +++ b/include/linux/shmem_fs.h
> @@ -67,7 +67,7 @@ extern unsigned long shmem_get_unmapped_area(struct file *, unsigned long addr,
>                 unsigned long len, unsigned long pgoff, unsigned long flags);
>  extern int shmem_lock(struct file *file, int lock, struct user_struct *user);
>  #ifdef CONFIG_SHMEM
> -extern bool shmem_mapping(struct address_space *mapping);
> +extern inline bool shmem_mapping(struct address_space *mapping);
>  #else
>  static inline bool shmem_mapping(struct address_space *mapping)
>  {
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 537c137698f8..7395d8e8226a 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -1152,7 +1152,7 @@ static void shmem_evict_inode(struct inode *inode)
>         struct shmem_inode_info *info = SHMEM_I(inode);
>         struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb);
>
> -       if (inode->i_mapping->a_ops == &shmem_aops) {
> +       if (shmem_mapping(inode->i_mapping)) {
>                 shmem_unacct_size(info->flags, inode->i_size);
>                 inode->i_size = 0;
>                 shmem_truncate_range(inode, 0, (loff_t)-1);
> @@ -2352,7 +2352,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode
>         return inode;
>  }
>
> -bool shmem_mapping(struct address_space *mapping)
> +inline bool shmem_mapping(struct address_space *mapping)
>  {
>         return mapping->a_ops == &shmem_aops;
>  }

Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>