Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 13 Nov 2020 10:19:29 -0500
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Laurent Vivier <lvivier@redhat.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: ERROR: modpost: "mac_pton" undefined!
Message-ID: <20201113101817-mutt-send-email-mst@kernel.org>
References: <202011131937.7Fy1Jnv1-lkp@intel.com>
 <71f5ec23-a1a7-8981-b924-412f4bbed9f6@redhat.com>
 <CAHp75Ve14rt_xDS40-bE2PGzo9JGKzqU0nPz_kbwngkn-upGVw@mail.gmail.com>
 <87d01fe1-1746-d31b-80aa-6adf286884c8@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d01fe1-1746-d31b-80aa-6adf286884c8@redhat.com>
Precedence: bulk

On Fri, Nov 13, 2020 at 02:19:31PM +0100, Laurent Vivier wrote:
> On 13/11/2020 14:12, Andy Shevchenko wrote:
> > On Fri, Nov 13, 2020 at 2:42 PM Laurent Vivier <lvivier@redhat.com> wrote:
> > 
> > ...
> > 
> >>> If you fix the issue, kindly add following tag as appropriate
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>>
> >>> All errors (new ones prefixed by >>, old ones prefixed by <<):
> >>>
> >>>>> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> >>
> >> I think something like this might fix the problem.
> > 
> > ...
> > 
> >> +       select NET
> >>         default n
> > 
> > You may also drop 'default n' :-)
> > 
> > But what I want to say is that API is under NET_UTILS, I dunno if the
> > driver requires full NET to be selected. And IIRC NET_UTILS is
> > selected by NET.
> 
> I think GENERIC_NET_UTILS might be enough.

Yes that is ok to select.
But really vdpa sim is a fake ethernet device, nothing
much is lost if it depends on NET too.

> The problem I have for the moment is to find or1k-linux-gcc for my Fedora 33...
> 
> Thanks,
> Laurent