Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1235435pxb; Fri, 13 Nov 2020 07:34:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQBkoO6ZxCh/uowVH7rMdBKa9hTgTMvnvQ9U8bvYGMPJZVuXxJVfSUFLtP5g+3D2Wl60AI X-Received: by 2002:a05:6402:31a5:: with SMTP id dj5mr3090745edb.325.1605281651393; Fri, 13 Nov 2020 07:34:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605281651; cv=none; d=google.com; s=arc-20160816; b=fBFjhAcIZCXxhfemyGj+q5W/elxSzT75NK2qT1c3w+Qa0Ozt+tDMzWypq80GVp101p bQzo1OgkrByOBGHx9aZC9KlUAy8NcYNbBwiNMf/wgmJz2zEFCQTHy7mVSGwRqE9bxeOk XXvWJo8UXlY9xBpokrm6fBue4IEWgx1vEopEz9eN6qbY+hRd1FLHYif0akzY8weP0nwW 3gNZneTz3g4H4kfVStdeqIcwR3XruVfgdAfaYaBifRezqly31cdjyzHeSpf0f61qetGo lpZUNDcIqGaOIDZpe2LKjwj89tJVPUThC2prdzmkIt0pcj0/CJQdkp393QIxxBlXObAm Xeow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=YSMnL8fIJNTPdCoIMBhUblJKFUrFsrZoa0SxVdO/OM8=; b=c5k318V/bsMvTClwOqsPSubKLa1qYhFa3jkOeVw2grfkoERDranaemg/Psfvv4XkRZ lcA46CKcESP1pVWT4+EQdpiNRHKElB788SdV4sW4WBG+M+QAmLX1F8SHKULUxcnpFaI2 D02o8rZsk0fAonwK7NsNb52hW0/6dogT1wg4qTCxtc1sYXIBxgV20Kbcal04c8k2VhPP OZ7QBtP7x5onqVITY+EzOKjSXcXTAjjfY5fwJ/sTGh1SS9wv8ryzKPAa1+336TWfv4Um xjLALSLDqBVvOlZHWqZPDNqXrmYYXogCWfVhFCdNZ3pJ+xyMJ6Am1V0Q/z/YbFzNThJ0 aagQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk1si5773546ejb.556.2020.11.13.07.33.49; Fri, 13 Nov 2020 07:34:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726831AbgKMPcP (ORCPT + 99 others); Fri, 13 Nov 2020 10:32:15 -0500 Received: from www62.your-server.de ([213.133.104.62]:55972 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbgKMPcP (ORCPT ); Fri, 13 Nov 2020 10:32:15 -0500 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1kdb3a-0000SZ-Oi; Fri, 13 Nov 2020 16:32:10 +0100 Received: from [85.7.101.30] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdb3a-000NMT-Iv; Fri, 13 Nov 2020 16:32:10 +0100 Subject: Re: [PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit To: Wang Hai , andrii.nakryiko@gmail.com, mrostecki@opensuse.org, john.fastabend@gmail.com Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201113115152.53178-1-wanghai38@huawei.com> From: Daniel Borkmann Message-ID: Date: Fri, 13 Nov 2020 16:32:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20201113115152.53178-1-wanghai38@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.4/25987/Fri Nov 13 14:19:33 2020) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/20 12:51 PM, Wang Hai wrote: > progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, > it should be closed. > > Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") > Signed-off-by: Wang Hai Applied & improved commit msg a bit, thanks!