Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH bpf-next 2/2] bpf: Expose bpf_d_path helper to sleepable
 LSM hooks
To:     Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@chromium.org>,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Jann Horn <jannh@google.com>,
        Hao Luo <haoluo@google.com>,
        Florent Revest <revest@chromium.org>,
        Brendan Jackman <jackmanb@chromium.org>
References: <20201112171907.373433-1-kpsingh@chromium.org>
 <20201112171907.373433-2-kpsingh@chromium.org>
 <63870297-fffe-f01e-9747-219b63c5d7f4@fb.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <8ca075b7-1fda-bd63-e2c2-68618d30b414@iogearbox.net>
Date:   Fri, 13 Nov 2020 16:33:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <63870297-fffe-f01e-9747-219b63c5d7f4@fb.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/13/20 4:18 AM, Yonghong Song wrote:
> 
> 
> On 11/12/20 9:19 AM, KP Singh wrote:
>> From: KP Singh <kpsingh@google.com>
>>
>> Sleepable hooks are never called from an NMI/interrupt context, so it is
>> safe to use the bpf_d_path helper in LSM programs attaching to these
>> hooks.
>>
>> The helper is not restricted to sleepable programs and merely uses the
>> list of sleeable hooks as the initial subset of LSM hooks where it can
> 
> sleeable => sleepable
> 
> probably not need to resend if no other major changes. The maintainer
> can just fix it up before merging.

Did while rebasing & applying, thanks everyone!

>> be used.
>>
>> Signed-off-by: KP Singh <kpsingh@google.com>
> 
> Acked-by: Yonghong Song <yhs@fb.com>