Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 13 Nov 2020 17:20:43 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     JC Kuo <jckuo@nvidia.com>, gregkh@linuxfoundation.org,
        jonathanh@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH v4 10/16] dt-bindings: phy: tegra-xusb: Add nvidia,pmc
 prop
Message-ID: <20201113162043.GD1408970@ulmo>
References: <20201016130726.1378666-1-jckuo@nvidia.com>
 <20201016130726.1378666-11-jckuo@nvidia.com>
 <20201019214046.GA3645734@bogus>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bjuZg6miEcdLYP6q"
Content-Disposition: inline
In-Reply-To: <20201019214046.GA3645734@bogus>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--bjuZg6miEcdLYP6q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 19, 2020 at 04:40:46PM -0500, Rob Herring wrote:
> On Fri, Oct 16, 2020 at 09:07:20PM +0800, JC Kuo wrote:
> > This commit describes the "nvidia,pmc" property for Tegra210 tegra-xusb
> > PHY driver. It is a phandle and specifier referring to the Tegra210
> > pmc@7000e400 node.
> >=20
> > Signed-off-by: JC Kuo <jckuo@nvidia.com>
> > ---
> > v4:
> >    new change to document "nvidia,pmc" prop
> >=20
> >  .../devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt      | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb=
-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-pa=
dctl.txt
> > index 38c5fa21f435..ea559baeb546 100644
> > --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl=
=2Etxt
> > +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl=
=2Etxt
> > @@ -54,6 +54,7 @@ For Tegra210:
> >  - avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply=
 1.05 V.
> >  - dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
> >  - hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1=
=2E8 V.
> > +- nvidia,pmc: phandle and specifier referring to the Tegra210 pmc@7000=
e400 node.
>=20
> 'Tegra210 pmc@7000e400' is kind of specific. Going to update this for=20
> every address and chip?
>=20
> If there's only one PMC, you can just find the compatible PMC node. Then=
=20
> you don't need a DT update.

I did advise against doing the lookup by compatible string because I
think it has a couple of downsides. On one hand it's going to create an
additional maintenance burden on the XUSB pad controller driver because
the PMC is usually not compatible between SoC versions, so for every new
SoC generation we'll have to add the PMC compatible string to the XUSB
pad controller driver.

On the other hand, this is new functionality and we can easily gate that
on the existence of this phandle, so it doesn't impact DT backwards
compatibility. That also has the advantage of explicitly listing the
dependency between the PMC and the XUSB pad controller in DT, so if we
ever do get around to come up with an even better mechanism to resolve
these dependencies than deferred probe, we do have the data already
available.

Thierry

--bjuZg6miEcdLYP6q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+uslsACgkQ3SOs138+
s6HwiQ//dbTTGapD1Ee9Mkr+c2pCCUsfskWRVv9zi0cNuboN9ivtOxVdVH3TXsVk
j1b/WKqiEVSdhacWRqGwkYwDtYf8FHtfyyS8ljhLYqp5kORoUoZ5hxFQ55BuBCD5
rA0TA+JgCcbXNA68HRBaZpArj57KjFS/qezrZwXnZl856G6yECN97SKgljS+nn7x
vSewLEFWuVuiEeANnKxHHWmm1/PuyQzZNtAYhfC6fZJi2nIeGT8+lh9AlehDcurW
pOpWAvCjJB5GMqfaSsTPV9DRmjSyk2zhvHaFcGKLK4qR/gqGJ3ZYk6Al/yCv3XFI
84wBd3j+EKiEayA+s0XDxVBddtEBPDckjJB6K9oulU5nrbGub2MQNSQl7piRoT1A
0vyhKqe6S7ttjOwOnfFexab8XAm2dseX2Wx/6mbjAM/+KRZnF23Kf2bIFvO4wZrw
SQwo8nWqodBUsr1kkU7ThCN+EJeGaIrQEwpwszwnwdlCSBk84BIAv4tXoI9fx11J
UrovlWcCdAntOpp0imlNr4hroP+NqZJPR36A8SwdO1fyM9MoBKflXBcZdcfiLOE0
5Vdlh43sYxkVEuedYGnqHZhNGLD77xWhbbrB86xxW7JmP6L0WC5GMw6oc/McVOAz
Q5bR1SDsZj5Es9HYlZQNUM0udhd087uBlIW9iSFyUQ981FlexMw=
=HnYy
-----END PGP SIGNATURE-----

--bjuZg6miEcdLYP6q--