Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208AbWHVMVc (ORCPT ); Tue, 22 Aug 2006 08:21:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932207AbWHVMVc (ORCPT ); Tue, 22 Aug 2006 08:21:32 -0400 Received: from relay.2ka.mipt.ru ([194.85.82.65]:34959 "EHLO 2ka.mipt.ru") by vger.kernel.org with ESMTP id S932204AbWHVMVb (ORCPT ); Tue, 22 Aug 2006 08:21:31 -0400 Date: Tue, 22 Aug 2006 16:20:43 +0400 From: Evgeniy Polyakov To: Christoph Hellwig Cc: lkml , David Miller , Ulrich Drepper , Andrew Morton , netdev , Zach Brown Subject: Re: [PATCH] kevent_user: use struct kevent_mring for the page ring Message-ID: <20060822122043.GB4815@2ka.mipt.ru> References: <12345678912345.GA1898@2ka.mipt.ru> <11561555871530@2ka.mipt.ru> <20060822115504.GB10839@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060822115504.GB10839@infradead.org> User-Agent: Mutt/1.5.9i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.7.5 (2ka.mipt.ru [0.0.0.0]); Tue, 22 Aug 2006 16:20:47 +0400 (MSD) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 35 On Tue, Aug 22, 2006 at 12:55:04PM +0100, Christoph Hellwig (hch@infradead.org) wrote: > Currently struct kevent_user.print is an array of unsigned long, but it's used > as an array of pointers to struct kevent_mring everyewhere in the code. > > Switch it to use the real type and cast the return value from __get_free_page / > argument to free_page. > > > include/linux/kevent.h | 2 +- > kernel/kevent/kevent_user.c | 31 +++++++++++-------------------- > 2 files changed, 12 insertions(+), 21 deletions(-) > > Signed-off-by: Christoph Hellwig I will apply this patch with small minor nit below. > if (idx >= u->pages_in_use) { > - u->pring[idx] = __get_free_page(GFP_KERNEL); > + u->pring[idx] = (void *)__get_free_page(GFP_KERNEL); Better cast it directly to (struct kevent_mring *). If there will not be any objectsion about syscall-based initialization, I will release new patchset tomorrow with your changes. Thank you, Christoph. -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/