Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1338869pxb; Fri, 13 Nov 2020 10:03:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMZIAB9HYMgr6zqv5yaiPIChX8fhM7t9sEEzgNv8BEnpMbnVRHsGmE/tsRUejOqOwJ3Xf7 X-Received: by 2002:a50:ab15:: with SMTP id s21mr3787820edc.88.1605290628276; Fri, 13 Nov 2020 10:03:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605290628; cv=none; d=google.com; s=arc-20160816; b=HZ9crky115VaPfF/HOt4Q/V8ftCaF/cPXwBtD5JD8mG8CWvvj7ML4SoMjo+KTdG1MT yLCiplGa7rpS8/X0zYzkqQ/sqNWACeR67XZoVuLSpFAEv+weLaTh46qQXwBYhgMusXJ8 h1xkjEoBrIWPHSXVVu++ZRuYblAcBngXpUsD62/Lf4U4g+HVfnLL+mevpulSBj0CkA5p aswuJnnhJYN1AiPb4E/3mVqxVzGpnHx+ukOSTFV2usBcvoEVZIhD8neEC+TkK+Fk5ZeR 31tjHgV3mqIG7jey/nHZdKnHRvp2Au1gfnaUfeU+NSfjbqsH4Z5JMvazpsEM/3QmJD// GGzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UjHJBIt+F+euaUZWdVCFve6WEU7koS9Vjtib6oMeH7M=; b=VDRJreAYQN4ggtNQbk1A+GWHU/fYjlHWhNf213G29ouUelIpaq7NNM3X1qR4vZE2GX vWgCZba5mkq212ZNDfLYQkztHL76BssItmBgRX9eqk+/5jsN8FoHZtZU1fIk+BLITzO/ 15j5OigHau+Yi4dmixncCOTTCJFjHw/Zw+zUgk7tiADq0LPiRswZ+V/25auHpHhsno1t VEsxDrxQvIA5AYzavqCq6YVKf8dahHie41YV3pLagc6oABtTxNtAD/QaCNKWJvEIKauw sPec3FNJdL4dUI5AC1HFhyeMnxKZBBAGgdblVBzZSig6mAbEeEW3nTkuMoikgYhKhQrY +m4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y41si6894807ede.192.2020.11.13.10.03.25; Fri, 13 Nov 2020 10:03:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbgKMSCD convert rfc822-to-8bit (ORCPT + 99 others); Fri, 13 Nov 2020 13:02:03 -0500 Received: from mailoutvs27.siol.net ([185.57.226.218]:52306 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726081AbgKMSCD (ORCPT ); Fri, 13 Nov 2020 13:02:03 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id D905E521624; Fri, 13 Nov 2020 19:02:00 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ibErSGJqCdUh; Fri, 13 Nov 2020 19:02:00 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id 8A966521623; Fri, 13 Nov 2020 19:02:00 +0100 (CET) Received: from jernej-laptop.localnet (89-212-178-211.dynamic.t-2.net [89.212.178.211]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Zimbra) with ESMTPA id AE2D4521626; Fri, 13 Nov 2020 19:01:59 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: airlied@linux.ie, daniel@ffwll.ch, Xiongfeng Wang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wangxiongfeng2@huawei.com, chenzhou10@huawei.com Subject: Re: [PATCH] drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() Date: Fri, 13 Nov 2020 19:01:59 +0100 Message-ID: <6119042.uhm7frSX9h@jernej-laptop> In-Reply-To: <1605186891-47282-1-git-send-email-wangxiongfeng2@huawei.com> References: <1605186891-47282-1-git-send-email-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Thanks for the patch. Dne Ĩetrtek, 12. november 2020 ob 14:14:51 CET je Xiongfeng Wang napisal(a): > Fix to return a negative error code from the error handling case instead > of 0 in function sun8i_dw_hdmi_bind(). > > Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") > Reported-by: Hulk Robot > Signed-off-by: Xiongfeng Wang > --- > drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index d4c0804..f010fe8 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c > @@ -208,6 +208,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct > device *master, phy_node = of_parse_phandle(dev->of_node, "phys", 0); > if (!phy_node) { > dev_err(dev, "Can't found PHY phandle\n"); > + ret = -ENODEV; That should be EINVAL because DT node doesn't have mandatory property. With that fixed, you can add: Reviewed-by: Jernej Skrabec Best regards, Jernej > goto err_disable_clk_tmds; > }