Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1429877pxb; Fri, 13 Nov 2020 12:26:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpWuVxxiEKbkUcRXPcJlnNAH14Q9+6v8DlLxieWz33aejdOUdzqWyMB/Ovs9q0J075NKW8 X-Received: by 2002:a17:906:4dc2:: with SMTP id f2mr3700895ejw.446.1605299201350; Fri, 13 Nov 2020 12:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605299201; cv=none; d=google.com; s=arc-20160816; b=eNhk39wLXSpmo3mO3l38QWO9MjAXlvk7dqBpoIsAVbZ2gfrAdXkF/FFAygN//xqbDo kfgJ4NRde9qKL5l0tEknoP4AdGfQiiRyY1o4hfkQ6RmkyvQQ70wqCREaGB54SqEr/NlL 8HnjGEnimqr4ulChzR6kAYOaYWr+Ifean1rv5ioYhUWs1zhYP8R4gIdYsgNWt0sW8gLu 8+vBWFdZqBvUSf45233gyfrfsjA7r2i69y7VGwJ/yglzFte/2i+Ohr1r4A51VdM9lI/K KAF0Qv75/Bemtg7wDzNc8nEK2Y9S27GRgH6UCi8fVv9fTWUU+9lliOdaUuX9qcQYm7xg 1ynw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=26k5Ykpq8ko3cdeDg3z0O22hPlAwcLFHBPMuuARRqmQ=; b=F1mEr5JcHw9PXftvkpG9PD6O1/mLDjBZr0WetKvUKEtJTw1jR2wve41N9A6YTSUa75 hEAEJ/aj/s5Xtv9F/fyc3WBWhweKB0zLelT7xl4ALD4u5bF4p6pi5lRmW1YY5ZgXO0c8 SfXdN6Li7pujIjCu/KJy0p8cuGk6XuXlumrnS/MPi8y7YwiNz/sJa0mkPIR8VC1yiPkE 9Ckz6VvHJax5LTV3uNFXJlQnNndO+kVUG6lEmITr1ef1UgAeoK70NHgb63rQQg3X2b2X fjkwRf5BYYn8RoSeGUk4P1OE2S0d2ZRtFYLgDVgWkN71AQSvojlRV6KK2PWck6/oLnaC slng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bRU/AGSv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si6509329edh.40.2020.11.13.12.26.14; Fri, 13 Nov 2020 12:26:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bRU/AGSv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbgKMUYr (ORCPT + 99 others); Fri, 13 Nov 2020 15:24:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49751 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgKMUYq (ORCPT ); Fri, 13 Nov 2020 15:24:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605299084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=26k5Ykpq8ko3cdeDg3z0O22hPlAwcLFHBPMuuARRqmQ=; b=bRU/AGSvsQfoyKAdAAO0tWpwx066psFImCR/HreSJ0MbXcwhBvLrQqUttHhHCfkzHySLsO 49sPx560J0OuoPfSNmnBWCuAjML3QetE/y05JHrIUulIM63X2stxS9pFWRxcZ/cm8Dmk43 ArIOTotI5SY7e7dT0wVWY9Sol6HA/cU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-5AHZ2R42OYaj2qrSFvyvpg-1; Fri, 13 Nov 2020 15:24:42 -0500 X-MC-Unique: 5AHZ2R42OYaj2qrSFvyvpg-1 Received: by mail-qk1-f197.google.com with SMTP id t64so7440348qkd.5 for ; Fri, 13 Nov 2020 12:24:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=26k5Ykpq8ko3cdeDg3z0O22hPlAwcLFHBPMuuARRqmQ=; b=XXeGZ3fuOWs8s1OR6JsvbRMLr2fAm1AF0oCKDfX4sapmuGSgkDzTXhVGY8egoqK4BC l85Ygf8SH9xBPKJ7JH2wRLEe/rfe4/CoJ7rQE2/KklMSQelXclkX9QHdZw+0L1ZPayUn N5MafH0RE02HMPck2E6xFFAdRuZYT8bUqdqHXzd8NJclJSMNmZ6PvK8JaPSGVt/VMusb qfJRu8Cext+7z2jB5nMlzNuZlMxiaGYeljkOcC+Rct4eYhpOhlIkUIx+GycsxIMoVg3M VBkCLy1z3zseiEfTepelQq7TxzHCh/gxHPEVf+bPsdB4BHHhcTZFSuds9+UdYoE5fRfB cg0Q== X-Gm-Message-State: AOAM530NAP40xuuL4CQfHEP6GOMitSakGSFNtWcMaFFrgXiF/VVamZeG hBWuU7Jzg+hiGRP/FM2abP3RxAX+pB/Xplo139ne7RiaX8NHbkuJLx/O9iu0kZ5ASBJdRQHKvuk TqUBAGyc+K8zAg/mse3vE0jcQ X-Received: by 2002:a37:8203:: with SMTP id e3mr3674940qkd.322.1605299081792; Fri, 13 Nov 2020 12:24:41 -0800 (PST) X-Received: by 2002:a37:8203:: with SMTP id e3mr3674913qkd.322.1605299081414; Fri, 13 Nov 2020 12:24:41 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id l79sm7706734qke.1.2020.11.13.12.24.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2020 12:24:40 -0800 (PST) Subject: Re: [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag To: richard.gong@linux.intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1605204403-6663-1-git-send-email-richard.gong@linux.intel.com> <1605204403-6663-2-git-send-email-richard.gong@linux.intel.com> From: Tom Rix Message-ID: Date: Fri, 13 Nov 2020 12:24:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1605204403-6663-2-git-send-email-richard.gong@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/20 10:06 AM, richard.gong@linux.intel.com wrote: > From: Richard Gong > > Add FPGA_MGR_BITSTREM_AUTHENTICATION flag for FPGA bitstream > authentication. Should improve this commit so explain what you mean authentication. it could mean 'it wrote correctly' or 'it was signed correctly' or something else. > > Signed-off-by: Richard Gong > --- > include/linux/fpga/fpga-mgr.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h > index 2bc3030..1d65814 100644 > --- a/include/linux/fpga/fpga-mgr.h > +++ b/include/linux/fpga/fpga-mgr.h > @@ -67,12 +67,15 @@ enum fpga_mgr_states { > * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first > * > * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed > + * > + * %FPGA_MGR_BITSTREM_AUTHENTICATION: do FPGA bitstream authentication > */ > #define FPGA_MGR_PARTIAL_RECONFIG BIT(0) > #define FPGA_MGR_EXTERNAL_CONFIG BIT(1) > #define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2) > #define FPGA_MGR_BITSTREAM_LSB_FIRST BIT(3) > #define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4) > +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5) A whitespace issue, the new BIT(5) should align with the others, so add two spaces to the others. Tom > > /** > * struct fpga_image_info - information specific to a FPGA image