Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 13 Nov 2020 21:29:04 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sowjanya Komatineni <skomatineni@nvidia.com>,
        Preetham Chandru <pchandru@nvidia.com>
Cc:     jonathanh@nvidia.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Add AHCI support for Tegra186
Message-ID: <20201113202904.GC1416567@ulmo>
References: <1605296218-2510-1-git-send-email-skomatineni@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C"
Content-Disposition: inline
In-Reply-To: <1605296218-2510-1-git-send-email-skomatineni@nvidia.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--NU0Ex4SbNnrxsi6C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 13, 2020 at 11:36:52AM -0800, Sowjanya Komatineni wrote:
> This series adds support for AHCI-compliant SATA to Tegra186 SoC.
>=20
> This series includes patches for
> - Converting text based dt-binding document to YAML.
> - Adding dt-bindings for Tegra186.
> - Enabling AHCI-compliance SATA for Jetson TX2.
> - Adding Tegra186 support to Tegra AHCI driver.
>=20
> Delta between patch versions:
> [v2]:	v1 feedback related to yaml dt-binding.
> 	Removed conditional reset order in yaml and updated dts files
> 	to maintain same order for commonly available resets across
> 	Tegra124 thru Tegra186.
>=20
>=20
> Sowjanya Komatineni (6):
>   arm: tegra: Change order of SATA resets for Tegra124
>   arm64: tegra: Change order of SATA resets for Tegra132 and Tegra210
>   dt-bindings: ata: tegra: Convert binding documentation to YAML
>   dt-binding: ata: tegra: Add dt-binding documentation for Tegra186
>   arm64: tegra: Enable AHCI on Jetson TX2
>   ata: ahci_tegra: Add AHCI support for Tegra186
>=20
>  .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 175 +++++++++++++++=
++++++
>  .../bindings/ata/nvidia,tegra124-ahci.txt          |  44 ------
>  arch/arm/boot/dts/tegra124.dtsi                    |   6 +-
>  arch/arm64/boot/dts/nvidia/tegra132.dtsi           |   6 +-
>  arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts |   4 +
>  arch/arm64/boot/dts/nvidia/tegra186.dtsi           |  28 ++++
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi           |   6 +-
>  drivers/ata/ahci_tegra.c                           |  60 +++++--
>  8 files changed, 263 insertions(+), 66 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra-ah=
ci.yaml
>  delete mode 100644 Documentation/devicetree/bindings/ata/nvidia,tegra124=
-ahci.txt

Preetham,

I vaguely recall discussing this with you previously and I think you had
mentioned that we may need changes to the XUSB pad controller to add
support for the SATA lanes on Tegra186 and later.

I've tested this patch and it does seem to work fine, so I wonder if
we're just getting lucky and the power on defaults are just right for
this use-case (I've only tested on Jetson TX2) or if we don't need any
support in the XUSB pad controller driver after all.

I'm not sure if you're subscribed to linux-tegra, but if not, here's a
link to this complete patchset:

	http://patchwork.ozlabs.org/project/linux-tegra/list/?series=3D214338

Thierry

--NU0Ex4SbNnrxsi6C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+u7IsACgkQ3SOs138+
s6E9QA/4i5KdCng+Ib/Kdpm0U0jnEdqiR60hXPVRLC1SpwTFZJ5/TPoab47/m8Y/
ca0Qw5F4cmfcWlwiSJ8VTj+F/6gxFWE8VT7oWNm9wBbql6rYCUoD77naEDjvYu0W
y4mZ1KHkqjO3bMgc9cSIljQ9MXZN6AEE62a+QlcwPPz5KAZaV6UkVizOhQRL0Fr1
DVDQGuLzY2b2mz6ymQT/25RL/F/3jnk6RK/y/UjuTWg8lYkAklGy2wlMTS0K5fPD
U172R5+byiHE2dn6UguzO159FAyERSQWLgPeHDhy7Opxm34/luTsGCV4sCqan1Zy
utctf518BXHs2X5UYt+l3Y2Zv6kF/rAMzvisnQg6QDKiKT0RN8LzKu1xvWEyq6O6
Xye3m2MquHds/Xp6pMOfKNmUyo3qC3c6y9G0eZ/HJwq8CYCDLGny8MkUmkFZGiul
ntlAQWrkWUFM4FFjRjAw1il0ATxRyBUAsn5wnqVFZz4+rfqbSrPCw3y53+rfMBs2
u8xnTFRcUrqTSuwEevCK6ihZMt396Yj1Tcn8+fhGnkwdmUTDNFPKC+o4boaR1LOt
5gxgxglGHiXu8gTUIpUGearql/bPDpoBfX9cUFtq0KXuJy1kTv9hrC5L/wX022Ot
oRKyedhVg42TX8541q1745iSXQ0k9puKRclcpRu9R4jqwQcMBw==
=0f5C
-----END PGP SIGNATURE-----

--NU0Ex4SbNnrxsi6C--