Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201112234907.3761694-1-rkir@google.com> <X645op2c70msQ+o3@kroah.com>
In-Reply-To: <X645op2c70msQ+o3@kroah.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Fri, 13 Nov 2020 12:39:54 -0800
Message-ID: <CAOGAQerDMua6cPxomAPdEHvCQYt66E=CL888WxeiqfKX4DPyOQ@mail.gmail.com>
Subject: Re: [PATCH] drivers: staging: retire drivers/staging/goldfish
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, Lingfeng Yang <lfy@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Greg, thank you for looking into this.

On Thu, Nov 12, 2020 at 11:44 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Nov 12, 2020 at 03:49:07PM -0800, rkir@google.com wrote:
> > From: Roman Kiryanov <rkir@google.com>
> >
> > Android Studio Emulator (goldfish) migrated
> > to Intel HDA.
>
> When was that?

At least one year, our 4.14 kernel does not include this option into
the defconfig, 4.4 includes it, but probably we don't need it.

> What about the other goldfish drivers?

There are only four goldfish divers we use in R: goldfish_pipe,
goldfish_battery, goldfish_sync and
goldfish_address_space. The goldfish_battery one is fully upstreamed
but I need to cleanup
Kconfig's (this is why I sent this patch). The goldfish_pipe one has
off-tree changes.
The goldfish_sync and goldfish_address_space are not in the kernel tree at all.

The rest can be retired - I will send patches.

The goldfish_pipe driver will be replaced by virtio-vsock and
virtio-console eventually.
We considered retiring goldfish_battery by switching to ACPI_BATTERY but ACPI
is not available (at least in GKI) on arm64.

Regards,
Roman.