Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113205233.827493-1-rkir@google.com> <20201113210730.GA1992396@bogus>
 <CAOGAQeq29S06+6M58qF0e4ivjzkZDg4+M7ffSK+FapbgmCBrLQ@mail.gmail.com>
In-Reply-To: <CAOGAQeq29S06+6M58qF0e4ivjzkZDg4+M7ffSK+FapbgmCBrLQ@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 13 Nov 2020 15:17:50 -0600
Message-ID: <CAL_Jsq+QjQxDh3_KDhgE_2A6DjA+gSyvknjrVfRFLMLz-p_M9A@mail.gmail.com>
Subject: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
To:     Roman Kiryanov <rkir@google.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Miodrag Dinic <miodrag.dinic@mips.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Lingfeng Yang <lfy@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 13, 2020 at 3:13 PM Roman Kiryanov <rkir@google.com> wrote:
>
> Hi Rob, thank you for looking into this.
>
> On Fri, Nov 13, 2020 at 1:07 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Nov 13, 2020 at 12:52:33PM -0800, rkir@google.com wrote:
> > > From: Roman Kiryanov <rkir@google.com>
> > >
> > > The only user of RTC_DRV_GOLDFISH is
> > > the MIPS flavor of Android Studio Emulator
> > > (goldfish) which should be also retired.
> > >
> > > Signed-off-by: Roman Kiryanov <rkir@google.com>
> > > ---
> > >  arch/riscv/Kconfig.socs    |   1 -
> > >  drivers/rtc/Kconfig        |  10 --
> > >  drivers/rtc/Makefile       |   1 -
> > >  drivers/rtc/rtc-goldfish.c | 216 -------------------------------------
> > >  4 files changed, 228 deletions(-)
> > >  delete mode 100644 drivers/rtc/rtc-goldfish.c
> >
> > What about the binding and MAINTAINERS?
>
> My bad, I will update those files too.

Though the binding is still used in arch/mips/generic/board-ranchu.c
and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The
latter was just added recently, so maybe premature to remove things?

Rob