Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1469749pxb; Fri, 13 Nov 2020 13:37:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/bFzgzsE88+GciSqYVGLCvbf4AIeDuJ1TQ+FpMibR8V7M8MUiK6d0xIAHFCtW7H4IOu5W X-Received: by 2002:a05:6402:170e:: with SMTP id y14mr4740335edu.115.1605303435684; Fri, 13 Nov 2020 13:37:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605303435; cv=none; d=google.com; s=arc-20160816; b=0p4OYQVhjIT61cfakUUasEx45qZ/cywI5osxiNNsKklJKpK9am+nkOOLjGTwodk6nG Kx3gsGYBG0l50OTwc05OveUZEq/XhNef8vWDSH4TE+RPWVQIdCYsi4SCev1MEnW0EM+T C7ko7gOugOMaNkOzabfgl/AcT/jjw/M8q2MREIqyaqEMgU8o2zoY3J6d8KKqpUZ/3cCc h3iKcNnFnLJ95p8iR0dDjnh3NEql/t9dayrdb8NJIvjTeXw7s5MMbYaDDgjtQLNRbknE S2bCahCWYzqhRcsWUY3xqHnJhxlI9dff6BM0I6a5F7bgKINeRwG+BINH7gAXsdLiCJuh 8+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=2cxwnj4lvvDa/xdNK2NIpsCOU23p/MBBEu1nguvpMQ0=; b=VITKD65/wgecbrjMv63DQQ4qW6dhqgxHc/FPinS5injPkkpm5YNitiY1WIXK9iG3l8 Nvx2krlbpzMLRmOPgX1goMYhwiABEhBw6bzcUgsrPRzvYWydRmMPW9VPeuezjuqd7uG4 mjNOY0jf+GG2JKqPVOTaWQ/SnLFt8Vl7AoGEoRfcz70EbnV1QSL6o4O+OogTX89YAOtY hzVBTwNYcsa/aI9Y+r5grIYE1rlPnE9DG/3jTU3ilGKKDj+Dr2o2c8hTQRTN04nkQTww LhSFTE8TnIVJ1b5CUhic0n35fHNAsNgj90Bpt70b4IfwCeq49yuV66UtwNl/IUxc/4za 3FQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=F+hAwde6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si7858241edi.434.2020.11.13.13.36.51; Fri, 13 Nov 2020 13:37:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=F+hAwde6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbgKMVfZ (ORCPT + 99 others); Fri, 13 Nov 2020 16:35:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726662AbgKMVfK (ORCPT ); Fri, 13 Nov 2020 16:35:10 -0500 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FE04C0613D1; Fri, 13 Nov 2020 13:35:09 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id t9so12460733edq.8; Fri, 13 Nov 2020 13:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2cxwnj4lvvDa/xdNK2NIpsCOU23p/MBBEu1nguvpMQ0=; b=F+hAwde6UWUQieKq1xiGdYeuNKYbhgRlHsUS4ewujyr+ooWFcafZg0SGWK4Eug0KU5 qwYCXXgFuKyir8p8JpwDRAa31Y9zkbnCA1AxlBKJbeG/mNV+h24kXXdXnvsCdwUyDeGe Ga7vUyszX49+tyaBj4u/3N6HaKeskkBqwNJgnI4npCrVs4yffLrT86byK9ZZ6QYi0E5r LS2/pvIBkEH7Fl3+hl3XHnUV77kkxTCY84ErHeqF/bVQSgFMiPMkx7oIJZAo8fN9yi8N EYmjKNLlKihLAwUxDgc4Fv7HcYrbuhBJ29xsEfaUv05vrQNMwVFlmyYqCLdWspwqCPuM B/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2cxwnj4lvvDa/xdNK2NIpsCOU23p/MBBEu1nguvpMQ0=; b=LWuXOt8kQ4cO7M9SR+8R5foiKfdGq5y1Vlqgz9gJuXaNlFX/opOyBobj/6HfcLi1t9 Rum5EBjmgvqndKep5DCEIrhEtybUhDFmS63p4iZWAeb6fBP2aTlKUwI5pKjbKBucDLhJ IdRvA+foHeq8rnnW2iSE1ifMhGjfeBd9YoR8qvsNkF76xCjjvX+6o+OHMid1bA8l/ZQR OOp5JFONMmZk17DvfmrteMejo5MzxLrPNlZDxpPGiDub/t3Ob7w5P/jMIZJxL6GgnkbM rsejQgk1+NmGil80btwQOfGVYyTvAd78j8dVI6c4izlGAxXCndvWzHqE8N55LycA2+cX cusw== X-Gm-Message-State: AOAM531gcfnNOAq1mfl+ZuCQdhT4ZwBpN2rddhiRTa7ZWKE2f4DAv6Cz 7MVDa4Ovga7oUBcRB+J15BoOcS6vjXU= X-Received: by 2002:a05:6402:33a:: with SMTP id q26mr4722857edw.224.1605303308074; Fri, 13 Nov 2020 13:35:08 -0800 (PST) Received: from ?IPv6:2a01:110f:b59:fd00:b15d:6782:80f1:8d19? ([2a01:110f:b59:fd00:b15d:6782:80f1:8d19]) by smtp.gmail.com with ESMTPSA id l25sm5019991eds.65.2020.11.13.13.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Nov 2020 13:35:07 -0800 (PST) Subject: Re: [PATCH] s5p-jpeg: hangle error condition in s5p_jpeg_probe To: Baskov Evgeiny , Andrzej Pietrasiewicz Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org References: <20201113160625.1281-1-baskov@ispras.ru> From: Jacek Anaszewski Message-ID: Date: Fri, 13 Nov 2020 22:35:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201113160625.1281-1-baskov@ispras.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Evgeiny, Thank you for the patch. There is a typo in the subject: s/hangle/handle/ Otherwise: Acked-by: Jacek Anaszewski On 11/13/20 5:06 PM, Baskov Evgeiny wrote: > If an error happens in jpeg_get_drv_data(), i.e. match fails, > jpeg->variant field is NULL, so we cannot access it. > > Consider device probe failed if jpeg->variant is NULL. -- Best regards, Jacek Anaszewski