Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1527507pxb; Fri, 13 Nov 2020 15:30:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNb8epJENK45lXnBWMHNp7h+7VIZzS0ttV2Q7g/hHh4otzC7PXK0e7I/pZ250nzynOo7/7 X-Received: by 2002:a17:906:46d2:: with SMTP id k18mr4228955ejs.33.1605310201420; Fri, 13 Nov 2020 15:30:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605310201; cv=none; d=google.com; s=arc-20160816; b=jC9O8yV7ahngq/ccww/+M4IKwNDV2otd2gfxoOUCtqDLp56E2d00yzhrqX4WPzOqrF vkW8sqhmcK3Aik/+Y8NvFsZAWXiMrYhStVbWaus67m/2D2BOelZQnMuck0+OTLPDMZk4 8H4DvXtgAma8XtdFFpiZUx1EmNohrLWZmEttjhbQav5preE/iB5ZCNMl9q/RJaj3rm5Y 508/Ed4nVMBODbW9niybJmU2GsiZZw6+ys00w0NBhrzxwP0gO7fwdbVRIL8Qf/fUxxKI w9jXkxd2h6uxuLpaU+yjp80xZBvpxEweFIVr0AYLT+GrqDP3+imRu7a0UHlWvE/DZwH4 Ui9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IGMXFjq050V+5ufsYu2caRw5lSMr8HpjwmDyb2v3Nz8=; b=NZgBdM/TdLCqFIA1eDfnsgKVXweFuExOeiUsTiBa//UB/YJtRVdBb6JwNAuAgDenEP B+2GPCKaQe9izDNsOKzcfZSeGAo44ASo22V3jLaI4kx9FWgllmnP6EhBi9xoSV9i0uWb L69sPOm9DdG5JjRCw4DrRPdNR7d41GXodsyDQnHwqVDrCxHgWaEnoVqSnonYS4/rLFdC brLMxbyUMnvI36E7oIDWr2CSGH2q/iOSVw4GS7esyDqIcrPMwTTqK60KP8tXRwvEMIKq GH1ItAt1cTRRyfubMWP+cm+wTvkSKaOuZtGqavD1THCPIJnlJKKCJMVEoCxIEuiNCjbY y5ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0NuvOODF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 61si7650652edc.400.2020.11.13.15.29.33; Fri, 13 Nov 2020 15:30:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0NuvOODF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbgKMX2J (ORCPT + 99 others); Fri, 13 Nov 2020 18:28:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:46632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgKMX2J (ORCPT ); Fri, 13 Nov 2020 18:28:09 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 728D12224F; Fri, 13 Nov 2020 23:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605310089; bh=TyTNr6dthjSmkZgrgaf8DURMMkJ5WSgZO7w2kKVizns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0NuvOODFEs7x0wHsurYcpaupbyC173TRYg/DSPerMt305c9MJYwTGwxJKvqCBKIfs mnkUHJSk5Bajjl8shD83gYA90o+tfu9FKyCSV25EFWIsV6i2VS+TyqDP1sE9rs99yQ +J0sRBRmPQT3lUVVtxoqA4PnAm302h9GkaxMbEsE= Date: Fri, 13 Nov 2020 15:28:07 -0800 From: Jakub Kicinski To: Grygorii Strashko Cc: "David S. Miller" , , Richard Cochran , Wang Qing , Sekhar Nori , , , Arnd Bergmann Subject: Re: [PATCH v5] net: ethernet: ti: am65-cpts: update ret when ptp_clock is ERROR Message-ID: <20201113152807.649e49d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201112164541.3223-1-grygorii.strashko@ti.com> References: <20201112164541.3223-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020 18:45:41 +0200 Grygorii Strashko wrote: > From: Wang Qing > > We always have to update the value of ret, otherwise the > error value may be the previous one. > > Fixes: f6bd59526ca5 ("net: ethernet: ti: introduce am654 common platform time sync driver") > Signed-off-by: Wang Qing > [grygorii.strashko@ti.com: fix build warn, subj add fixes tag] > Signed-off-by: Grygorii Strashko > Acked-by: Richard Cochran Thanks for handling this, applied!