Message-ID: <44EB1BEB.60202@goop.org>
Date: Tue, 22 Aug 2006 07:59:55 -0700
From: Jeremy Fitzhardinge <jeremy@goop.org>
User-Agent: Thunderbird 1.5.0.4 (X11/20060613)
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: Rusty Russell <rusty@rustcorp.com.au>, Andi Kleen <ak@muc.de>,
       Andrew Morton <akpm@osdl.org>,
       virtualization <virtualization@lists.osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] paravirt.h
References: <1155202505.18420.5.camel@localhost.localdomain>	 <44DB7596.6010503@goop.org> <1156254965.27114.17.camel@localhost.localdomain>
In-Reply-To: <1156254965.27114.17.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1481
Lines: 31

Alan Cox wrote:
> It would be nice not to export it at all or to protect it, paravirt_ops
> is a rootkit authors dream ticket. I'm opposed to paravirt_ops until it
> is properly protected, its an unpleasantly large security target if not.
>   

Do you have an example of an attack which would become significantly 
easier with pv_ops in use?  I agree it might make a juicy target, but 
surely it is just a matter of degree given that any attacker who can get 
to pv_ops can do pretty much anything else.

> It would be a lot safer if we could have the struct paravirt_ops in
> protected read-only const memory space, set it up in the core kernel
> early on in boot when we play "guess todays hypervisor" and then make
> sure it stays in read only (even to kernel) space.
>   

Yes, I'd thought about doing something like that, but as Arjan pointed 
out, nothing is actually read-only in the kernel when using a 2M 
mapping.  It's also ameliorated by the fact that some of the entrypoints 
are never used at runtime, because the code has been patched inline (but 
I don't think it would ever be desirable to patch every entrypoint, 
since some are just not worth the effort, complexity or obfuscation 
which result from patching).

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/