Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To:     Ioana Ciornei <ciorneiioana@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: RE: [PATCH RESEND net-next 17/18] net: phy: adin: implement generic
 .handle_interrupt() callback
Thread-Topic: [PATCH RESEND net-next 17/18] net: phy: adin: implement generic
 .handle_interrupt() callback
Thread-Index: AQHWud1/Uwiz5TV09E2lrqLBEwezb6nHLXrA
Date:   Sat, 14 Nov 2020 06:38:12 +0000
Message-ID: <DM6PR03MB4411E0161C1FF4C1904AD97DF9E50@DM6PR03MB4411.namprd03.prod.outlook.com>
References: <20201113165226.561153-1-ciorneiioana@gmail.com>
 <20201113165226.561153-18-ciorneiioana@gmail.com>
In-Reply-To: <20201113165226.561153-18-ciorneiioana@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 816351bc-dc21-45ea-4cdb-08d88867dc09
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2020 06:38:12.6321
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5LiSAEyXe5S3Dzh61YY2I3yfFBnzEu3dp03hwvV/TqidMwrinpaFTYQCmFCOb7/SkIJQPC2M5ea9GGVY7vMHtaM+ZXaFH3IieHFpO524HPk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2523
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-14_01:2020-11-13,2020-11-14 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0
 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011140040
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ioana Ciornei <ciorneiioana@gmail.com>
> Sent: Friday, November 13, 2020 6:52 PM
> To: Andrew Lunn <andrew@lunn.ch>; Heiner Kallweit <hkallweit1@gmail.com>;
> Russell King <linux@armlinux.org.uk>; Florian Fainelli <f.fainelli@gmail.=
com>;
> Jakub Kicinski <kuba@kernel.org>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Ioana Ciornei <ioana.ciornei@nxp.com>; Ardelean, Alexandru
> <alexandru.Ardelean@analog.com>
> Subject: [PATCH RESEND net-next 17/18] net: phy: adin: implement generic
> .handle_interrupt() callback
>=20
> [External]
>=20
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>=20
> In an attempt to actually support shared IRQs in phylib, we now move the
> responsibility of triggering the phylib state machine or just returning I=
RQ_NONE,
> based on the IRQ status register, to the PHY driver. Having
> 3 different IRQ handling callbacks (.handle_interrupt(),
> .did_interrupt() and .ack_interrupt() ) is confusing so let the PHY drive=
r
> implement directly an IRQ handler like any other device driver.
> Make this driver follow the new convention.
>=20

Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
>  drivers/net/phy/adin.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c index
> 3727b38addf7..ba24434b867d 100644
> --- a/drivers/net/phy/adin.c
> +++ b/drivers/net/phy/adin.c
> @@ -479,6 +479,24 @@ static int adin_phy_config_intr(struct phy_device
> *phydev)
>  			      ADIN1300_INT_MASK_EN);
>  }
>=20
> +static irqreturn_t adin_phy_handle_interrupt(struct phy_device *phydev)
> +{
> +	int irq_status;
> +
> +	irq_status =3D phy_read(phydev, ADIN1300_INT_STATUS_REG);
> +	if (irq_status < 0) {
> +		phy_error(phydev);
> +		return IRQ_NONE;
> +	}
> +
> +	if (!(irq_status & ADIN1300_INT_LINK_STAT_CHNG_EN))
> +		return IRQ_NONE;
> +
> +	phy_trigger_machine(phydev);
> +
> +	return IRQ_HANDLED;
> +}
> +
>  static int adin_cl45_to_adin_reg(struct phy_device *phydev, int devad,
>  				 u16 cl45_regnum)
>  {
> @@ -879,6 +897,7 @@ static struct phy_driver adin_driver[] =3D {
>  		.set_tunable	=3D adin_set_tunable,
>  		.ack_interrupt	=3D adin_phy_ack_intr,
>  		.config_intr	=3D adin_phy_config_intr,
> +		.handle_interrupt =3D adin_phy_handle_interrupt,
>  		.get_sset_count	=3D adin_get_sset_count,
>  		.get_strings	=3D adin_get_strings,
>  		.get_stats	=3D adin_get_stats,
> @@ -902,6 +921,7 @@ static struct phy_driver adin_driver[] =3D {
>  		.set_tunable	=3D adin_set_tunable,
>  		.ack_interrupt	=3D adin_phy_ack_intr,
>  		.config_intr	=3D adin_phy_config_intr,
> +		.handle_interrupt =3D adin_phy_handle_interrupt,
>  		.get_sset_count	=3D adin_get_sset_count,
>  		.get_strings	=3D adin_get_strings,
>  		.get_stats	=3D adin_get_stats,
> --
> 2.28.0