Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113205233.827493-1-rkir@google.com> <20201113210730.GA1992396@bogus>
 <CAOGAQeq29S06+6M58qF0e4ivjzkZDg4+M7ffSK+FapbgmCBrLQ@mail.gmail.com>
 <CAL_Jsq+QjQxDh3_KDhgE_2A6DjA+gSyvknjrVfRFLMLz-p_M9A@mail.gmail.com>
 <CAOGAQepCsj63yZzJJHKCdHTenkWNLc_v=Ab6PgvS3hzqZMwH8A@mail.gmail.com>
 <CAOGAQepW3pbbjK9KpPZR1BwGY-CGF7V_pTY_9dw98XPgUKYFHg@mail.gmail.com>
 <X68aZ/Dgm7CObQmH@kroah.com> <tencent_3801BEAE39670E174105E007@qq.com> <X6+SP0RGUUAL40ty@kroah.com>
In-Reply-To: <X6+SP0RGUUAL40ty@kroah.com>
From:   Huacai Chen <chenhc@lemote.com>
Date:   Sat, 14 Nov 2020 16:59:37 +0800
Message-ID: <CAAhV-H5uak2Txvj3-yZz5HJxiE8tUKyGEibVa8LkqJOYn2+ACQ@mail.gmail.com>
Subject: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Roman Kiryanov <rkir@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Lingfeng Yang <lfy@google.com>, Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi, Greg,

On Sat, Nov 14, 2020 at 4:16 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote:
> > Hi, All,
> >
> > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish
> > as well, so I think  we should keep it in kernel.
>
> And more importantly, if you rely on this, are you willing to maintain
> it?
I think it will break the booting of MIPS/RISCV QEMU virtual machines,
because RTC is an necessary device.

For the maintenance, I don't know whether Goldfish RTC depends on the
code under drivers/platform/goldfish. If not, I think I can maintain
it (I think other parts of Goldfish will be removed, I'm able to
maintain RTC but I'm not able to maintain the whole).

Huacai

>
> thanks,
>
> gre gk-h