Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1780741pxb;
        Sat, 14 Nov 2020 01:59:04 -0800 (PST)
X-Google-Smtp-Source: ABdhPJynyFCKPQAKGrlhxi0hWnJLoz4f52j8OvCS/O9pJpctjTzCy2snK+wRvc4BbQKFo6xvDJrj
X-Received: by 2002:a50:a40f:: with SMTP id u15mr6891467edb.307.1605347944187;
        Sat, 14 Nov 2020 01:59:04 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605347944; cv=none;
        d=google.com; s=arc-20160816;
        b=FK5sccnDgPQkm1pjNdluxBrGV/pEIZkwIjW2ABNJb3pZ0uq4e3cL8hCdWf9DXgnnnv
         5G9db49th1kL9QjvVj7eiflPbLQhitMnHH6nvS/iO5vk+JIP8hJ5sJUTLFgNaTh0eQuB
         +lb4Th+SGROwoepNbVt5iQLc0TPS7FpEEDZaCrcQf3cASlEHDvTK/e5PMmEh54bmBx0T
         98NWB98Ar6dHaB2qaArNxO6rlG//aHdxP6aNGq+OZjbqx7JKQ9I3nZtM3Ji5Ofcvetu6
         VFh/WYZlcIOZaso3Cu+Ci9Q6WoLHRFTB5tZ53oum1qzpQ/yCu3kczhPKoku/npfJAj9H
         xFHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=+n6yYogmRexBCLu5vXUhODLO5ei1Y5DE7pKG9eRAO9Y=;
        b=X9OGuiN+4DOMmdfiqD4jC7TxDWt6Rk56pKC5q7W2Odn3F8/2N3ZjbUeEFfbc6IOnGV
         Kx5sTw0fqxkxVjb6qQoRoVVwTqyRow5XPum5OSf2rvxu7xr1KSS+hl+F2JmuvAw5STqn
         ZyNdYqKjkw4/i0CDptyJKQ/EGzKcA7YhnH4F1riUQFLDY9z8q7vV8lonVU9/Xm4gN7bA
         NoiDJZpDNiGlUTJzAdjWTfIfONyB3M8QMdfw+yHOWLwiqjngGwdMQ0vW8TekyLKhnedK
         NqMoiShVGbAQDZh1Hs/X39l1eG2DAj/XgZEMe/RggnsHkg8uIwRz4d4k4M2ZSGcQIuin
         duLg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d12si7534563eje.365.2020.11.14.01.58.41;
        Sat, 14 Nov 2020 01:59:04 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726735AbgKNJx4 (ORCPT <rfc822;austinkernel.kim@gmail.com>
        + 99 others); Sat, 14 Nov 2020 04:53:56 -0500
Received: from verein.lst.de ([213.95.11.211]:49875 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726584AbgKNJx4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 14 Nov 2020 04:53:56 -0500
Received: by verein.lst.de (Postfix, from userid 2407)
        id 7BD3F68B05; Sat, 14 Nov 2020 10:53:54 +0100 (CET)
Date:   Sat, 14 Nov 2020 10:53:54 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, hughd@google.com, hch@lst.de,
        hannes@cmpxchg.org, yang.shi@linux.alibaba.com,
        dchinner@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/16] mm/swap: Optimise get_shadow_from_swap_cache
Message-ID: <20201114095354.GD19102@lst.de>
References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-4-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112212641.27837-4-willy@infradead.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 12, 2020 at 09:26:28PM +0000, Matthew Wilcox (Oracle) wrote:
> There's no need to get a reference to the page, just load the entry and
> see if it's a shadow entry.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>