Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1791461pxb; Sat, 14 Nov 2020 02:26:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkfMe0R6nIqauxua++AshieTZk7ZkkedmZgVFg7GCLiRd9kBmmV5J+5RJWZ1emYrU0r1Li X-Received: by 2002:a17:906:d9dd:: with SMTP id qk29mr6277227ejb.487.1605349560383; Sat, 14 Nov 2020 02:26:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605349560; cv=none; d=google.com; s=arc-20160816; b=Zwl5pqexz+q1fjmQvzRK59bPYnJbM88ZaUJg1Iw4l+yLDMLwga4rVY/ENoqudLid+R nL5OT0bPUkz4SoYk8SlmY7CXmXasLxV5H7SoIjmvERmV2NbG8z1hbB1HILKsZrjqh5SX RkCDBWnrRy1ryQkpA2ntXawyfDiclFka9SJG/M5dtMbE2SOdSs0UCy5KiZHtdBTdv+sK ku99ty/Vijlt4mSUtkvoJVLZIgYIaL7WgAh5G024Lqpac1aWoGyip2i1hkRDcJhXgooD bhLBijKHt6ccucVwN/K6e313t7u6p4sHrlOXhjethocQA8uCfT4fsRPimbKQ6O1n1hPM HlJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=0auvJvpUWhtvwUGJG3cbwwhG0N/+UhgnAmdLVYprEnY=; b=MalGhDh3LRj4SEWnLAOYK/W/xpmsV5Rqno4ym4dFz5KWDjOSNH0J50Bq8/EpUrkteT hXEvfDGT+r9VlIoRVkgeS/Y3N86Aj7w1MokG3C4iUV/maVPUJhRlli4CdnK2AzVKzPK2 6GWld3Y/FeQ20NGR50bhbSTyG/jZUPFoQAiXYWhrUCVfFwJNLpU411+go9tOvUXdjbI6 WOeL3gnJoKGJwbjWSzhUdrVWKhNiYIPNnLmtpjYFiIKHEkFkl7luflRED3norm4v5jqw cFQNqh0XnzKCAT7A/1++Swn+zCBmJcXIcOJcVsPDYnVZZH87pUbOg0Zl7Bwp33fagtt2 YjQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si7641818ejf.629.2020.11.14.02.25.38; Sat, 14 Nov 2020 02:26:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726727AbgKNKVj (ORCPT + 99 others); Sat, 14 Nov 2020 05:21:39 -0500 Received: from verein.lst.de ([213.95.11.211]:50018 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbgKNKVj (ORCPT ); Sat, 14 Nov 2020 05:21:39 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 1AC5968AFE; Sat, 14 Nov 2020 11:21:33 +0100 (CET) Date: Sat, 14 Nov 2020 11:21:33 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, hch@lst.de, hannes@cmpxchg.org, yang.shi@linux.alibaba.com, dchinner@redhat.com, linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v4 13/16] mm: Pass pvec directly to find_get_entries Message-ID: <20201114102133.GN19102@lst.de> References: <20201112212641.27837-1-willy@infradead.org> <20201112212641.27837-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112212641.27837-14-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 09:26:38PM +0000, Matthew Wilcox (Oracle) wrote: > + pvec->nr = ret; > return ret; Do we need to return the number of found entries in addition to storing it in the pagevec?