Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 14 Nov 2020 15:46:41 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 1/4] device: provide devm_krealloc_array()
Message-ID: <20201114154641.0258f4ee@archlinux>
In-Reply-To: <20201102142228.14949-2-brgl@bgdev.pl>
References: <20201102142228.14949-1-brgl@bgdev.pl>
        <20201102142228.14949-2-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon,  2 Nov 2020 15:22:25 +0100
Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> When allocating an array of elements, users should check for
> multiplication overflow or preferably use one of the provided helpers
> like: devm_kmalloc_array().
> 
> This provides devm_krealloc_array() for users who want to reallocate
> managed arrays.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

+CC Greg KH. 

As this is going into a very generic place I'd like a relevant ack.
That file is a bit of a wild west for acks, but Greg seems most
appropriate person.

So Greg, any comments on this one?

Thanks,

Jonathan

> ---
>  include/linux/device.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 5ed101be7b2e..e77203faea55 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -226,6 +226,17 @@ static inline void *devm_kmalloc_array(struct device *dev,
>  
>  	return devm_kmalloc(dev, bytes, flags);
>  }
> +static inline void *
> +devm_krealloc_array(struct device *dev, void *ptr, size_t new_n,
> +		    size_t new_size, gfp_t gfp)
> +{
> +	size_t bytes;
> +
> +	if (unlikely(check_mul_overflow(new_n, new_size, &bytes)))
> +		return NULL;
> +
> +	return devm_krealloc(dev, ptr, bytes, gfp);
> +}
>  static inline void *devm_kcalloc(struct device *dev,
>  				 size_t n, size_t size, gfp_t flags)
>  {