Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1954621pxb; Sat, 14 Nov 2020 07:57:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJypC498nmuKnIcrM8NgQOT6KLYJImHoKbkILMSmSMOTBQ8OeOMBRA83UgwVLYm8S5exSk+t X-Received: by 2002:a50:dec5:: with SMTP id d5mr8114226edl.362.1605369477214; Sat, 14 Nov 2020 07:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605369477; cv=none; d=google.com; s=arc-20160816; b=Hm5j0Ctry7EvN4+hIEr7sL9zT2Ff4Jc0ijfUsnslMCbiU9SEgH08Vl37b6SKG1doc1 yLBFZtdTr1m3iAhL0WKfFJaF8kxftL7hW3WoEkwu5TEOVya14EdJZXYXSrfC5Jm6mHnQ Hi7VCkvDuv6vdC0zKn3r7PDr1jTIiR6EHm17hxFzqwn+ti5wEpD2plyq2+u+iEb7EhnJ pMalr1/HEQU5/6ZggPb6bmKVRae5x7KzxjUY0UdgMG6x5C9kjGwrr/GOEl/1OS1ho4ZP Zy3Hj8ex5CKuolFpY4nblgvW455tRjMHSsU8kliJtWYbhmkceZPVYW38YFXUuHxvv74I XLAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=WdylbP2NfyT0+ghuXLqODU9fXbydrot5yDDVn5EPhdA=; b=EYWfVSY6kUyleG+ftvopMJd+NyaMC7+6RMS7uxuuGHRN66wEOTu8JrKZmrPR3higoL ez/owy0a35V1nWLw9Jl9W4j0yzzyzhoI/LYWOTr05ObodgeUvH9CboP7JkkCkQfJpWu5 MoLALAq4+VAEjQawabB6j7DvMUjKQvqrrr1mcunoFInd2kjB5cYBBXaZ+SvLdl2JBwhv wqHK64PoTxBPqGwbEsG3v6Kh1x/FL6ODxaNPZubFVZ0hptEcb+qJRjU5Dxh4JZNyhhR6 ++KQ1Zg7rX4VqqIx10XledKpg3RaOzMgKFh62s17mEcwrfkYY1oxOUG0r/DR7HapF4uD 0dXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cyL8deSC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si8376568edq.16.2020.11.14.07.57.33; Sat, 14 Nov 2020 07:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cyL8deSC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgKNPyE (ORCPT + 99 others); Sat, 14 Nov 2020 10:54:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38382 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbgKNPyD (ORCPT ); Sat, 14 Nov 2020 10:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605369242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WdylbP2NfyT0+ghuXLqODU9fXbydrot5yDDVn5EPhdA=; b=cyL8deSCO7/wqaSw/uWrp3u4Z8tkcZP+JA0ODKZ8MxK7NqogvDA2skNmwheFudRQ4hP1Z7 vMdJCvSdt+B7b0Wyjz41cj36QDT00I0lbXPAwCR+5JBRVYdMj1l4jX50H8kkv0qj/LczvF F77trezAA/ja/lJ2XmR93GOQ48UTG+c= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-8jJLJyzvPPiHvkgRkGSNmg-1; Sat, 14 Nov 2020 10:53:57 -0500 X-MC-Unique: 8jJLJyzvPPiHvkgRkGSNmg-1 Received: by mail-qt1-f198.google.com with SMTP id z14so7686898qto.8 for ; Sat, 14 Nov 2020 07:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WdylbP2NfyT0+ghuXLqODU9fXbydrot5yDDVn5EPhdA=; b=Z/UsrB2vx2k+YB2Q1qNg8YeMdgCEc4cG+rqggziCBqh/+g9MaGi7DYOIihNjeItQ5H Nd3phjiHGYzgtcp27jUQ6poL99QDkSG0Xmv87AZ4iI09Yggy5revE3q1xjhVOPr1ArFN UVYJx2GQgGr6tsXi0AMIov1aX4jePHJVSg/1TDzPQFkZf79YDclk1pQNWgkJH9zYZhl6 X01HpnWZ1LKxHjqUhSaS5TUh41LDK/gqXUAXot8b5kuQDnI4uIdV6GDhN1PMdl+hs36v ely/krFnDgbmQL27iIbs26G3yuQUmvVFWznIX8jGs+o7Sn0f7ZYSUHEz12Hn4PsGPDHG B6Qg== X-Gm-Message-State: AOAM531+p3jRIQNvSlBXRWt8vK6boT0qvdy4j5gF3sPBOUcwUA2DDgcX vE+TnuNaScFss/IY1GAYtr3RmElktfceub/y4oqwhKLzVJDFr/ObWOUYen6km51f4XBBAT25W+Q Dz4Q7JOOhiTvkrS8UJ5eX5CgE X-Received: by 2002:a37:e12:: with SMTP id 18mr4265875qko.179.1605369237482; Sat, 14 Nov 2020 07:53:57 -0800 (PST) X-Received: by 2002:a37:e12:: with SMTP id 18mr4265861qko.179.1605369237249; Sat, 14 Nov 2020 07:53:57 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id c199sm506723qke.111.2020.11.14.07.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2020 07:53:56 -0800 (PST) Subject: Re: [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag To: Richard Gong , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1605204403-6663-1-git-send-email-richard.gong@linux.intel.com> <1605204403-6663-2-git-send-email-richard.gong@linux.intel.com> <4dd9a747-05f3-1cca-22a6-35681677223d@linux.intel.com> From: Tom Rix Message-ID: <28d2ace8-315a-3eaf-75da-88a4e90ea045@redhat.com> Date: Sat, 14 Nov 2020 07:53:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4dd9a747-05f3-1cca-22a6-35681677223d@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/20 6:30 AM, Richard Gong wrote: > >> A whitespace issue, the new BIT(5) should align with the others, so add two spaces to the others. >> > > There is only one space, also I ran checkpatch with strict option and didn't see any whitespace issue. > > In the original patch, BIT(0) to BIT(4) align themselves. I am not sure why we see differently in email. > >  #define FPGA_MGR_PARTIAL_RECONFIG      BIT(0) >  #define FPGA_MGR_EXTERNAL_CONFIG       BIT(1) >  #define FPGA_MGR_ENCRYPTED_BITSTREAM   BIT(2) >  #define FPGA_MGR_BITSTREAM_LSB_FIRST   BIT(3) >  #define FPGA_MGR_COMPRESSED_BITSTREAM  BIT(4) > +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5) > > To align BIT(5) with others, I have to use additional tab to BIT(0) to BIT(4). But I don't think I should make such change on them, agree? The existing table of #defines has aligned values for BIT(0) to BIT(4) Your addition of BIT(5) value has an inconsistent alignment with the others BIT(0) to BIT(4) The alignment of all the values should be consistent. Tom > > Regards, > Richard > >> Tom >> >>>     /** >>>    * struct fpga_image_info - information specific to a FPGA image >> >