Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1956789pxb; Sat, 14 Nov 2020 08:01:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7Mf1DzwWbWEJUoWqW/V0DCfZ7OWlYeKMvmckawuLOOYm02gbFsTiMEx5E5cah5zZ7LIXt X-Received: by 2002:a17:906:2e8e:: with SMTP id o14mr7274724eji.324.1605369714335; Sat, 14 Nov 2020 08:01:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605369714; cv=none; d=google.com; s=arc-20160816; b=QaJ7P7HBLtDAASPijmxIobTZN5/rS1K87AfJeo8xUqkxWMMsPU4I7PJ7TynK6QIojm yOuFm5/MCVXMYnFJkXw628BnpMHbfCgihJTA6Y9ejLFa0pGyWUVLCZTwQu4VCGt/NlYF AsMa+Cy5CvkMuVa34iPigHx54hrPEaaYTGt8t2Y2NdT5FOWMxb+YwKEsszM9XWDXEIFF bwPSAMCovpT6moZiC454l23T4vXNDtq9iRFG5PiplFx04FTJewFWILPg9IOFJS8lL1Pb FcVouaKfD/Omj5WmGPwvjv8lUBCbaen4YIDrPvkPfbF1ab0ua1lO0S+DB1rwe0mRs2+H QZwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=/z1B79VS6bauxShMToBYrbJVsmG7jXKkwYFCUP4q2iU=; b=sC/m3ErYPdWkZJ4UWwXQHWCCrHpIof00QYX3t/EG7XlBipbZW93cupgF/L0fcBRG2g YUjEIx4eo2dCWqpnA+7477hIWGHIspt5du/o8GPPOA0cNSUGXnoq0QVa+0pLVHunJUlX myopAllSngbtMR2mDT59eJUraOG9yl1JwL7m4SYRliB+3itSQoykCSQrQwkuPZj1I+nz YMwF69pdvKS3Q0iARXossWvuCz4wtP5l/TX5n8pFPSJ5O+tOB9aq2pe8gSYsfPUxbje+ sxB9ZYfkk3fdZ0Sfb+joSWOtbAPtbIodJJrZRKhAOgzy+6eKJzH+e1EcTNDiTrdm2zPE AdjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hyAN7C0s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq11si8541224edb.332.2020.11.14.08.01.31; Sat, 14 Nov 2020 08:01:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hyAN7C0s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgKNP7n (ORCPT + 99 others); Sat, 14 Nov 2020 10:59:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30298 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbgKNP7n (ORCPT ); Sat, 14 Nov 2020 10:59:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605369581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/z1B79VS6bauxShMToBYrbJVsmG7jXKkwYFCUP4q2iU=; b=hyAN7C0sAXQphKcCSD81WauBw24Iec1+M6FPx9UiMt2bsbfnDUmrAe1wozrV3VInanD75b 741gG/XlPe4IHZS6mBp+CQjp4F5JGYkioeTtVajw7iLacvFfsWFFZZO/M1V54g/6l7/RzA p0yS1cXwwhh9L30n33KqnFG27MtudkU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-oJPcW7HOOJWpqg8psn6VvA-1; Sat, 14 Nov 2020 10:59:39 -0500 X-MC-Unique: oJPcW7HOOJWpqg8psn6VvA-1 Received: by mail-qk1-f199.google.com with SMTP id x2so8597014qkd.23 for ; Sat, 14 Nov 2020 07:59:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/z1B79VS6bauxShMToBYrbJVsmG7jXKkwYFCUP4q2iU=; b=oQfIiCIUrHbY8FAr/02JNDABx/q//BFAZe0bzcK7oogFL2RB/Z04mg+M/5IfpOl4o5 Xnf8+RFof797SM2JC0Jgcas7pkLcSii6gTNwBRRDF77qgdtVlYpHsUXrbylI5uoN9KlN 8lPxnJ1NqMcnFwZv+BSQly6tbW4zFwcpHKerelaD2YzT4QYK4ONe7DVf9wLdqNsku/n+ Lzycs61L3bqvRdWkFcIHCmvG4Afv80Hp8EIU0T+MYYkuC1jVkCToME2xXciPrzPoiAoc xIkZHm8Hn0nUAkvJ8KgILBrEUyKZLroMLwrOvL+IkV6hJ5wBav8rXMNwAHPsGm6KEKz4 WEZQ== X-Gm-Message-State: AOAM530khCVygHwrI/pxd+D2WmkqlzPHe+8G6oq1sRlTUjUeEB9V0RlK d1yIoquvH4BVRRXCTb1eIoEnY9yHBhwHWkxtBb5Vvv3AMf651rKBaA9/jRbHGPO/kpn6UeqAEIR 2ro/FUGQJ6kswDOVCw1FWzuwK X-Received: by 2002:a37:b8c:: with SMTP id 134mr7093959qkl.483.1605369579485; Sat, 14 Nov 2020 07:59:39 -0800 (PST) X-Received: by 2002:a37:b8c:: with SMTP id 134mr7093948qkl.483.1605369579307; Sat, 14 Nov 2020 07:59:39 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id r18sm8779627qtp.89.2020.11.14.07.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2020 07:59:38 -0800 (PST) Subject: Re: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property To: Richard Gong , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1605204403-6663-1-git-send-email-richard.gong@linux.intel.com> <1605204403-6663-4-git-send-email-richard.gong@linux.intel.com> <94ccfc8d-ecf9-7782-9044-d3c0cb862118@redhat.com> From: Tom Rix Message-ID: Date: Sat, 14 Nov 2020 07:59:37 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/20 6:52 AM, Richard Gong wrote: > Hi Tom, > >>>       prior to OS boot up. >>>   - encrypted-fpga-config : boolean, set if the bitstream is encrypted >>> +- authenticate-fpga-config : boolean, set if do bitstream authentication >> >> The list is mostly in alphabetical order so the new 'authenticate-... ' should go at the top. >> > > The original list is not in alphabetical order. The order of partial-fpga-config, external-fpga-config and encrypted-fpga-config here follows the implementation in the of-fpga-region.c file. > > So authenticate-fpga-config should follow the way, correct? > This is why i say 'mostly' .. In general when listing options for a user to read, you should make it easy for them to find the option they are looking for.  Ordering them alphabetically is an obvious but not the only way.  I am not asking for you to fix the whole table, just what you are adding. If there is a better way to organize them please propose the method. Tom >> Improve what you mean by 'authentication' similar to my comment in the first patch. >> > > Will do in the version 2 submission. > > Regards, > Richard > >> Tom >> >>>   - region-unfreeze-timeout-us : The maximum time in microseconds to wait for >>>       bridges to successfully become enabled after the region has been >>>       programmed. >> >