Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 14 Nov 2020 17:17:24 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2 1/4] device: provide devm_krealloc_array()
Message-ID: <X7ADFLwEpUHkTiT+@kroah.com>
References: <20201102142228.14949-1-brgl@bgdev.pl>
 <20201102142228.14949-2-brgl@bgdev.pl>
 <20201114154641.0258f4ee@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201114154641.0258f4ee@archlinux>
Precedence: bulk

On Sat, Nov 14, 2020 at 03:46:41PM +0000, Jonathan Cameron wrote:
> On Mon,  2 Nov 2020 15:22:25 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> 
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > 
> > When allocating an array of elements, users should check for
> > multiplication overflow or preferably use one of the provided helpers
> > like: devm_kmalloc_array().
> > 
> > This provides devm_krealloc_array() for users who want to reallocate
> > managed arrays.
> > 
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> +CC Greg KH. 
> 
> As this is going into a very generic place I'd like a relevant ack.
> That file is a bit of a wild west for acks, but Greg seems most
> appropriate person.
> 
> So Greg, any comments on this one?

As there is only 1 user of this function in the patch series, you don't
save any extra code space here, I don't think this is worth it.

We are seeing less and less gains from these new devm_* additions, and
only more confusion and problems with them.  So perhaps don't add this?
I don't think it is needed.

thanks,

greg k-h