Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113000508.14702-1-aouledameur@baylibre.com> <20201113000508.14702-2-aouledameur@baylibre.com>
In-Reply-To: <20201113000508.14702-2-aouledameur@baylibre.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat, 14 Nov 2020 20:13:18 +0100
Message-ID: <CAFBinCC92FfvFt1aAspkF_Mrrtu_QpS327TN2=9Yc3tWMTcu_w@mail.gmail.com>
Subject: Re: [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset
 controller use
To:     Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc:     Kevin Hilman <khilman@baylibre.com>,
        Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-amlogic@lists.infradead.org,
        Jerome Brunet <jbrunet@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Amjad,

On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur
<aouledameur@baylibre.com> wrote:
[...]
> @@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy)
>  {
>         struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy);
>
> +       reset_control_rearm(priv->reset);
please move reset_control_rearm after clk_disable_unprepare as
mentioned on the other patch to clean things up in reverse order of
initialization

>         clk_disable_unprepare(priv->clk);


Thank you
Martin