Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2054617pxb; Sat, 14 Nov 2020 11:25:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1XkJ+TwoT7TxhcfQeofcFyH12GeFWnlQe+tOdT1IeGnrCEjXNAjDe8nITZMiAM3hlEpr+ X-Received: by 2002:aa7:d3cc:: with SMTP id o12mr8743668edr.36.1605381954172; Sat, 14 Nov 2020 11:25:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605381954; cv=none; d=google.com; s=arc-20160816; b=XWtMlqei4PwGOSsHiY4WH+g8Dx4gTuZ7bRNi9jYj41HbPLGokyrNbxUH+btSEDuGkp 0ccpiCY6F8CkggQeEP5RLgOSx59PwsZj7Eu4Skhl73jcMrCflU7yDamyB9qMsp+UH1iD 3dB7bBmMOnRhpsmHbMaPoRlzDqqyEW+LHUCIwNWXlkKVxkOcqxO0RSb/+JaJf/fkRynE J/Uxe0M4aitcAVNOh+Ftbfxwtryl++djFiHyol2rljGYS6Vy9w/nGxhUxkJWLReG1vIC o/96rb03YRKiGapH8XIztDn+L5gSMv95ZBQe9JcLepyNYx5exuN+/NW28AHz4yo/bVQ1 gq5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=j25Idu1kfdF9J1xjDRLWAgLZcaG0lLINwPgAYc4UNWs=; b=ypJCil9AO/XDqFh16QYz16mnCT0X5Rl9v9364HDd3W+/1PQlNc4PwfbFV+wz9HnnI1 zqkKuUHKhqMnjdwExR+9bSKzx+AHmXs5e6CPNliYtZGz5SEx/94jxOwHkOwkPPKPknnl 2JLMToeKW01NmUrqlGJ0B4QwjLkHQx+oC4pEPq0ngEQWzVDPIWUpJPylGgb0lMNut7j7 J90vYzoCOf4bEaNQczXcKmuOP5GCNE6GSclYgMMeVHHIXi2qoRll4MKlL5CCk4W/DsO2 HWKX95SifUVhLb+5llNKkkYyTsdM+kVp6v0g/sSi8WgLGh7amANConV9OTEa8sg6Qt+Y 0+VA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si1924666edx.449.2020.11.14.11.25.30; Sat, 14 Nov 2020 11:25:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbgKNTWI (ORCPT + 99 others); Sat, 14 Nov 2020 14:22:08 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:60057 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbgKNTWH (ORCPT ); Sat, 14 Nov 2020 14:22:07 -0500 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 52C8660004; Sat, 14 Nov 2020 19:22:02 +0000 (UTC) Date: Sat, 14 Nov 2020 20:22:02 +0100 From: Alexandre Belloni To: Jonathan Cameron Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Nicolas Ferre , Ludovic Desroches , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] iio: adc: at91_adc: use devm_input_allocate_device Message-ID: <20201114192202.GC5272@piout.net> References: <20201113212650.507680-1-alexandre.belloni@bootlin.com> <20201113212650.507680-8-alexandre.belloni@bootlin.com> <20201114171340.2bf0d61e@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114171340.2bf0d61e@archlinux> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2020 17:13:40+0000, Jonathan Cameron wrote: > On Fri, 13 Nov 2020 22:26:48 +0100 > Alexandre Belloni wrote: > > > Use devm_input_allocate_device to allocate the input device to simplify the > > error and remove paths. > > > > Signed-off-by: Alexandre Belloni > > This one I'm less keen on. Whilst it's obviously not a problem in > this particular case I'd ideally like to keep the remove order > as the exact reverse of probe - that makes it easy to review changes > quickly. > > Now, you could easily enough make this fine by using devm for the > other items that happen before this (dev_add_action_or_reset needed > in a few cases). > Right, I'll drop it for now.