Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20201106094820.30167-1-lukas.bulwahn@gmail.com>
References: <20201106094820.30167-1-lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] clk: remove unneeded dead-store initialization
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Tom Rix <trix@redhat.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        clang-built-linux@googlegroups.com,
        kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech,
        linux-kernel@vger.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org
Date:   Sat, 14 Nov 2020 12:32:34 -0800
Message-ID: <160538595432.60232.9813667976586248163@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Lukas Bulwahn (2020-11-06 01:48:20)
> make clang-analyzer on x86_64 defconfig caught my attention with:
>=20
>   drivers/clk/clk.c:423:19:
>   warning: Value stored to 'parent' during its initialization is never re=
ad
>   [clang-analyzer-deadcode.DeadStores]
>           struct clk_core *parent =3D ERR_PTR(-ENOENT);
>                            ^
>=20
> Commit fc0c209c147f ("clk: Allow parents to be specified without string
> names") introduced clk_core_fill_parent_index() with this unneeded
> dead-store initialization.
>=20
> So, simply remove this unneeded dead-store initialization to make
> clang-analyzer happy.
>=20
> As compilers will detect this unneeded assignment and optimize this anywa=
y,
> the resulting object code is identical before and after this change.
>=20
> No functional change. No change to object code.
>=20
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---

Applied to clk-next