Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2084638pxb;
        Sat, 14 Nov 2020 12:42:32 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwOUxl2KAfUZCUJwEHvrjDHJufXuSDv+qu/42Uf61MhsYiMXbHdbVz7KRF8XDux4/tyImF3
X-Received: by 2002:a17:906:134e:: with SMTP id x14mr8206440ejb.173.1605386552117;
        Sat, 14 Nov 2020 12:42:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605386552; cv=none;
        d=google.com; s=arc-20160816;
        b=f647gpkWrqP7KDcvZQ2752wMZQbLBWTutlEmNpXpK/eh+/SOfCViwDSyFg9jrDXrC3
         Jz81vP/jd6Onh3HcP0gRRGReILPMu+RfY1hZbxEzTnOQPyxnjDMB1iNrxCTzNtzTkY3Z
         ccVKyH2EYIcJKLmoyRING2lKbl4xITnInvkHGROjlaHR3Syx8g6Q74ehZCbAWijaNqUF
         y6CwAtCt1PgGUC4tELZUyKLfuagfN2PN8h76+xcXf8LjpG35txc8keJh4OupgrktZ2Ph
         YZ4go0E91RdHYppsGRuS2PpYb0286QgM86Dnj7BFJuYvKOZ3WeuXbznNyQWPC3Tklqp+
         PMGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=veovKS90fzOYF3DdZvPlGJcMjei+2SsOoiIjsMjA6vI=;
        b=eYRBnogqVQiAbHI1kBVY+ec55mMv+6OZHABk2v8jePvzdOfRxnN5yLLqlpQ3kXN9FX
         ehTFtvy2MuxH/aOBsIjTsTtGTv9oXJZqrQYV9J7ZsGSW52UjWClA2lNqDpUD8tBoybyN
         okeNk3YceSLs2gzJEVN56VuMyW+OIdtBgnW4PLI0UaqenhVl26bpviSmgmEyjeqiB35O
         KQL37XU4eGQVv038RYCzRZWEe23F32Wp7sgB7gMFEhWLFX0PdwK58U6hjXZXiR/0g2By
         6LwN3ACYS25zuW33L7SQjZwEa42lhyR/lEdn1h8IzWCitSo2e7S2A9AEnVXTmYska7LU
         WatQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=wnMlnHXL;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l31si8693376edl.524.2020.11.14.12.42.09;
        Sat, 14 Nov 2020 12:42:32 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=wnMlnHXL;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726291AbgKNUgP (ORCPT <rfc822;xc.haze2010@gmail.com>
        + 99 others); Sat, 14 Nov 2020 15:36:15 -0500
Received: from mail.kernel.org ([198.145.29.99]:33582 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726265AbgKNUgO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 14 Nov 2020 15:36:14 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 1BD43223EA;
        Sat, 14 Nov 2020 20:36:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605386174;
        bh=ZdY8nPUPIIA8CI/+vJjOcvrkMUrXAxTH/bkxfEqtSek=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=wnMlnHXLQG7hL0zyMjIGXQf07Bdddqg1nXbCrnxR1d2yZ2/rUaTIQDMHEYqqrvyVW
         0EqXmJHLp+vnBZeYVuTS3zcA1/hB76ZKk9qImTI8V/GUDyERN70HoAhE3fSUej2KQm
         nISzOh6dXJ9ed95RMmb4t2M75m0dzAJaDMsvHN4M=
Date:   Sat, 14 Nov 2020 12:36:13 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <nicolas.ferre@microchip.com>, <claudiu.beznea@microchip.com>,
        <davem@davemloft.net>, <harini.katakam@xilinx.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: macb: Fix passing zero to 'PTR_ERR'
Message-ID: <20201114123613.2e52fb49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201112144936.54776-1-yuehaibing@huawei.com>
References: <20201112144936.54776-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 12 Nov 2020 22:49:36 +0800 YueHaibing wrote:
> Check PTR_ERR with IS_ERR to fix this.
> 
> Fixes: cd5afa91f078 ("net: macb: Add null check for PCLK and HCLK")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Looks like a cleanup PTR_ERR() should return 0 for NULL AFAICS.

Applied to net-next, thanks!