Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201113205233.827493-1-rkir@google.com> <20201113210730.GA1992396@bogus>
 <CAOGAQeq29S06+6M58qF0e4ivjzkZDg4+M7ffSK+FapbgmCBrLQ@mail.gmail.com>
 <CAL_Jsq+QjQxDh3_KDhgE_2A6DjA+gSyvknjrVfRFLMLz-p_M9A@mail.gmail.com>
 <CAOGAQepCsj63yZzJJHKCdHTenkWNLc_v=Ab6PgvS3hzqZMwH8A@mail.gmail.com>
 <CAOGAQepW3pbbjK9KpPZR1BwGY-CGF7V_pTY_9dw98XPgUKYFHg@mail.gmail.com>
 <X68aZ/Dgm7CObQmH@kroah.com> <tencent_3801BEAE39670E174105E007@qq.com>
In-Reply-To: <tencent_3801BEAE39670E174105E007@qq.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Sat, 14 Nov 2020 14:01:50 -0800
Message-ID: <CAOGAQepHauLriqfkxzMfyB=5MqUrX0XRTt==eSN=Q48CjKiEYQ@mail.gmail.com>
Subject: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
To:     =?UTF-8?B?6ZmI5Y2O5omN?= <chenhc@lemote.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Huacai Chen <chenhuacai@gmail.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Lingfeng Yang <lfy@google.com>, Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Hancai,

do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a
patch to retire it.

Regards,
Roman.

On Sat, Nov 14, 2020 at 12:06 AM =E9=99=88=E5=8D=8E=E6=89=8D <chenhc@lemote=
.com> wrote:
>
> Hi, All,
>
> Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as=
 well, so I think  we should keep it in kernel.
>
> Huacai
>
>
> ------------------ Original ------------------
> From:  "Greg KH"<gregkh@linuxfoundation.org>;
> Date:  Sat, Nov 14, 2020 07:43 AM
> To:  "Roman Kiryanov"<rkir@google.com>;
> Cc:  "chenhc"<chenhc@lemote.com>; "Paul Walmsley"<paul.walmsley@sifive.co=
m>; "LKML"<linux-kernel@vger.kernel.org>; "Lingfeng Yang"<lfy@google.com>; =
"Rob Herring"<robh@kernel.org>;
> Subject:  Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH
>
>
>
> On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote:
> > +Greg KH
> >
> > On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov <rkir@google.com> wrote:
> > >
> > > Hi Hancai,
> > >
> > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio=
.dts which
> > > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81.
> > > We (Android Studio Emulator aka "goldfish") do not support MIPS anymo=
re.
> > > Do you know if goldfish-rtc still works and is assumed to be availabl=
e?
>
> I've dropped this patch from my trees now, please feel free to resend
> when you have an updated version.
>
> thanks,
>
> greg k-h