Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2131979pxb; Sat, 14 Nov 2020 14:56:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFpJphE+Y+ZIXMRZJEWoJb/0PzWwqmjiJM0b7RiLpW8lBNjaMEU4r8vg5zLlIWGFibXlee X-Received: by 2002:a17:906:4d93:: with SMTP id s19mr8524603eju.271.1605394610911; Sat, 14 Nov 2020 14:56:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605394610; cv=none; d=google.com; s=arc-20160816; b=C/Ddu9g0K9cxNLYBYgSSKHuIhNO6tk90ZYMhKBmOQCh4s6PhJfaAshf6g8bjug7XkX 3GeJFb3CjNqRPBjrxjnH3sYW4F9dFCBnOlDyDzg74DcjH+i0sM2Gw8GlLvF2xdEiXxvK MA4GMOek+2PmLJv0Excjj84CHHwY2KPnyLX5isN2rJPnp1A8h6qn1+15M7ZdPTh/Uzp7 nATb1E7aM4PjW4nD/7RqP7tdXD8j4+dOldruLvnAgJ+KMw/0CDOPMnRyyfqudaiBKfPy pmNSG+akfXYoEV5tghbrZn7HfvSqnTAPcxCWd8m1c58KUDS164hUohcS5aK4GSup+XlE phtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=n6+yEBf20fXnHdKeZTFVRcHBnxFFejLbocRNG1BT5KU=; b=J4laAvC6mZXdeFVu5Vr+Rlc0RL9V7d9Zt9FuEDjyu251TqHAb6MDWYROucC9TVZoq3 6+iy9XHdlUXVRHkUCuOktZ0qykmH6RKoc3G4FEuwtxQuePUxpeAt5EOCw+2aL8o5HYrl qZP0ayEAtpDQAm6JkioysyLydAIEi/ffxlXuW89kUR0WO8nzF2ffTtwQ7JA0ptuSlV6x oQpM1qE+XEFvCmFiOnK4KyEzKVOsy5O5fkfqk/eMJqFeufXxVLpEFc7BLBBowBjRakEo S+6c9wWJ1pQ9ZXBR7ZyW3Soj4yJZpW1IUiEvnOc/LnAParzJhDWBGKYzOdEaak7ciTJu p8Ug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si6374009edi.374.2020.11.14.14.56.27; Sat, 14 Nov 2020 14:56:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgKNWwy (ORCPT + 99 others); Sat, 14 Nov 2020 17:52:54 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:29541 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbgKNWwy (ORCPT ); Sat, 14 Nov 2020 17:52:54 -0500 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E1B00240003; Sat, 14 Nov 2020 22:52:50 +0000 (UTC) From: Alexandre Belloni To: bcm-kernel-feedback-list@broadcom.com, a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, Xu Wang , linux-rtc@vger.kernel.org Cc: Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare Date: Sat, 14 Nov 2020 23:52:45 +0100 Message-Id: <160539432950.849809.8243938283788159741.b4-ty@bootlin.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201113074538.65028-1-vulab@iscas.ac.cn> References: <20201113074538.65028-1-vulab@iscas.ac.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Nov 2020 07:45:38 +0000, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. Applied, thanks! [1/1] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare commit: 910d002d84df21da61cadba92dd510ece5e46312 Best regards, -- Alexandre Belloni