Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 14 Nov 2020 17:58:28 -0500
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc:     jic23@kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check
Message-ID: <X7BhFOA9uPAUluv0@shinobu>
References: <20201111163807.10201-1-vilhelm.gray@gmail.com>
 <20201114224827.GQ4556@piout.net>
 <20201114225113.GR4556@piout.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LF/5iLACl9VFrJcf"
Content-Disposition: inline
In-Reply-To: <20201114225113.GR4556@piout.net>
Precedence: bulk


--LF/5iLACl9VFrJcf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote:
> On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote:
> > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote:
> > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible valu=
es
> > > for CMR. This patch fixes the action_get() callback to properly check
> > > for these values rather than mask them.
> > >=20
> > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
> > > Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> >=20
> > > ---
> > >  drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------
> > >  1 file changed, 10 insertions(+), 6 deletions(-)
> > >=20
> > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counte=
r/microchip-tcb-capture.c
> > > index 039c54a78aa5..142b389fc9db 100644
> > > --- a/drivers/counter/microchip-tcb-capture.c
> > > +++ b/drivers/counter/microchip-tcb-capture.c
> > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct coun=
ter_device *counter,
> > > =20
> > >  	regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr=
);
> > > =20
> > > -	*action =3D MCHP_TC_SYNAPSE_ACTION_NONE;
> > > -
> > > -	if (cmr & ATMEL_TC_ETRGEDG_NONE)
> > > +	switch (cmr & ATMEL_TC_ETRGEDG_BOTH) {
>=20
> BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask.

You're right, let me resubmit this patch with that change since it'll be
much clearer.

By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is
Kamel the maintainer of this driver? I'd like to get a proper entry
added so we have a point of contact in case of future bugs and changes.

Thanks,

William Breathitt Gray

--LF/5iLACl9VFrJcf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+wYPUACgkQhvpINdm7
VJJI+hAA6HMTVn7T0kWkHIRa+CGFPliJYVMVECIiMeMVFSzfB8b//RWxSoYUY8Cr
Oj1fCgZT/pddPB9kcvLkycgFrUJN1dO3MHvYtChn67moUIK2WdIRYXVKUNlpyOy0
cIzSznULfJYcqHYVROIaIjgBpLtQiBhsG857kqSxCni4UOWMjWHPnNU+XXPAy79U
ORp0XAgViBrGpT1cD9z3mXO9TdIP49fm2An2rORC5Eu8UPMk+cpBKekhk+VwURUj
H2T3Q61EwxH2iicDHip7rRzSlKQEDvXghIWYCzlLhJ99V+sOBaZD7qbO+FflOjJp
T9z0+q3tuXhSrwQ6mWvISLVOddf2q2HcgnW2W45TUO4jyxlVXwIKWpwTsF+PKjBF
tMYlrojud53CGe+jqA83baBEUw1k81Fioo5Tr7jjaIu3jRBN/clzIx4ontwU7rY8
et4OidOH/10ozD9ABffQOoOTDz/2jD6Ub+iQGNnCAVcOZJD8l29LjOIr1AldmeM/
7ssqDXHI6f8FKxZDjjfcKlhFhEGrribZZ8/r1YdpkZgQkZ+35nH4gN9W2WOGZkrP
lLd0z1o1ygkkhm/uQ0FDIKes4qoGPzwCV4u4d1BqW+DOTo5JX1pFZhXivqhkbVtw
ux5Y7OIEeHjXQ+9xf6IToefeJ30zrGHI4tWgrI8bhnV0nY4geUw=
=1W7P
-----END PGP SIGNATURE-----

--LF/5iLACl9VFrJcf--