Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TvmTn46vySo7pcxa47A5u9mYhZuP+Xc79DOOsTZ3zInTPUYNsSONV354cKhgb0Hlm1KaEJA3CD
 dBKb/x2o+VBg==
IronPort-SDR: M5fUKI7iZIgMhYqL/ymWNDzdoK+ygXYGPr0w85UP00EhfFJDNnrMpgKWtZ2CF8LdNg41YT1NV+
 /fHa66mBenjQ==
Date:   Sun, 15 Nov 2020 05:05:24 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
Subject: Re: [PATCH] perf stat: Take cgroups into account for shadow stats
Message-ID: <20201115130524.GL894261@tassilo.jf.intel.com>
References: <20201114023643.211313-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201114023643.211313-1-namhyung@kernel.org>
Precedence: bulk

> @@ -57,6 +59,9 @@ static int saved_value_cmp(struct rb_node *rb_node, const void *entry)
>  	if (a->ctx != b->ctx)
>  		return a->ctx - b->ctx;
>  
> +	if (a->cgrp != b->cgrp)
> +		return (char *)a->cgrp < (char *)b->cgrp ? -1 : +1;

This means the sort order will depend on heap randomization, 
which will make it harder to debug.

Better use something stable like the inode number of the cgroup.

Do we have the same problem with other filters?

The rest of the patch looks good to me.

-Andi