Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2518959pxb; Sun, 15 Nov 2020 07:35:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwqzsDKYWNEncvehMlUBzp9LZhuh91i9zMwMlThQ9NuiflzeicdIFOYX1eg18RnFHwW6Sd X-Received: by 2002:a50:daca:: with SMTP id s10mr3252558edj.263.1605454502862; Sun, 15 Nov 2020 07:35:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605454502; cv=none; d=google.com; s=arc-20160816; b=mtRvB7Va/bR+DudcsDP5JjwwnSPzAwFu7cue3f6vBmbujYtmGajmk/oelAOMuMln4C guEKmHY5LXnslUbWkDbtUzGtOkh7LKWhAsbsbOIpjT1zxw5gjinOz1PcOgqQ1Fcnae/5 0szejernWiya7IQZ02ReDL6WZNzCZ6XZ6GIFreZ+kqzFPaxTBs++3sVxb7ynpvTr9wYz ggMO8LNZrkIENKB2AjtVocIozEhVVaMEz673WBPhWyU5fIMu5BMc6oZiS0B8efppvBaR gSf55g74RfXB4JmRya4fxdMx0GezWHz5doJRUPJhocDr7S5YGW/O3MH30mgeZpagzVBJ sDZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=K6fFm6sdgFDN8u2HMh+lusNGTMdRY2U8OVVQ7jKN4cc=; b=kStu8Y2aZYr1KQ521h78SC7JuJ6TL9RyPsc8TJYIoeCtepZFFBDXmF6TgUfOV/lRqP 4TXU1AWE2gQ1I3x5Hr7te1P27z1JMjDqMaPuKWfBKuw5ziALTuWBiMg8D1ZaMnDI+Oo1 eRr1vhCTbhxAENkosFJW2B47fIZBWi+3/CFeRJf68hyziMx1eff1KiKitUyXuDMK0iqa Zf9rWJsp3YhjWlNBlF8Hxcf4jS32nFnYFomuoeCFOL+KFZ+7ZKp061TPgrRSK4ymnBip vSomPfo8EFWnefTzKTShk93z/MvIDSiuvzTi+yCoPERCVCV7sA+6WzchGYUQNl3dRfRZ QW5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si10097314edj.168.2020.11.15.07.34.39; Sun, 15 Nov 2020 07:35:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727184AbgKOOF3 (ORCPT + 99 others); Sun, 15 Nov 2020 09:05:29 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:35142 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbgKOOF2 (ORCPT ); Sun, 15 Nov 2020 09:05:28 -0500 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1keIeg-009fU2-79; Sun, 15 Nov 2020 07:05:22 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1keIef-0003D4-7f; Sun, 15 Nov 2020 07:05:21 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Bjorn Helgaas Cc: Thomas Gleixner , "Guilherme G. Piccoli" , linux-pci@vger.kernel.org, kexec@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, andi@firstfloor.org, lukas@wunner.de, okaya@kernel.org, kernelfans@gmail.com, ddstreet@canonical.com, gavin.guo@canonical.com, jay.vosburgh@canonical.com, kernel@gpiccoli.net, shan.gavin@linux.alibaba.com, "Rafael J. Wysocki" References: <20201114212215.GA1194074@bjorn-Precision-5520> Date: Sun, 15 Nov 2020 08:05:05 -0600 In-Reply-To: <20201114212215.GA1194074@bjorn-Precision-5520> (Bjorn Helgaas's message of "Sat, 14 Nov 2020 15:22:15 -0600") Message-ID: <87v9e6n2b2.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1keIef-0003D4-7f;;;mid=<87v9e6n2b2.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+YuU7K8slUpoLdruiB0niDW9O6RxUm9go= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMNoVowels,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4994] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Bjorn Helgaas X-Spam-Relay-Country: X-Spam-Timing: total 501 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 9 (1.7%), b_tie_ro: 7 (1.5%), parse: 1.35 (0.3%), extract_message_metadata: 5 (1.0%), get_uri_detail_list: 2.5 (0.5%), tests_pri_-1000: 4.5 (0.9%), tests_pri_-950: 1.44 (0.3%), tests_pri_-900: 1.18 (0.2%), tests_pri_-90: 128 (25.4%), check_bayes: 126 (25.1%), b_tokenize: 9 (1.9%), b_tok_get_all: 11 (2.1%), b_comp_prob: 3.5 (0.7%), b_tok_touch_all: 98 (19.6%), b_finish: 0.92 (0.2%), tests_pri_0: 333 (66.5%), check_dkim_signature: 0.55 (0.1%), check_dkim_adsp: 2.4 (0.5%), poll_dns_idle: 0.49 (0.1%), tests_pri_10: 2.1 (0.4%), tests_pri_500: 6 (1.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn Helgaas writes: > [+cc Rafael for question about ACPI method for PCI host bridge reset] > > On Sat, Nov 14, 2020 at 09:58:08PM +0100, Thomas Gleixner wrote: >> On Sat, Nov 14 2020 at 14:39, Bjorn Helgaas wrote: >> > On Sat, Nov 14, 2020 at 12:40:10AM +0100, Thomas Gleixner wrote: >> >> On Sat, Nov 14 2020 at 00:31, Thomas Gleixner wrote: >> >> > On Fri, Nov 13 2020 at 10:46, Bjorn Helgaas wrote: >> >> >> pci_device_shutdown() still clears the Bus Master Enable bit if we're >> >> >> doing a kexec and the device is in D0-D3hot, which should also disable >> >> >> MSI/MSI-X. Why doesn't this solve the problem? Is this because the >> >> >> device causing the storm was in PCI_UNKNOWN state? >> >> > >> >> > That's indeed a really good question. >> >> >> >> So we do that on kexec, but is that true when starting a kdump kernel >> >> from a kernel crash? I doubt it. >> > >> > Ah, right, I bet that's it, thanks. The kdump path is basically this: >> > >> > crash_kexec >> > machine_kexec >> > >> > while the usual kexec path is: >> > >> > kernel_kexec >> > kernel_restart_prepare >> > device_shutdown >> > while (!list_empty(&devices_kset->list)) >> > dev->bus->shutdown >> > pci_device_shutdown # pci_bus_type.shutdown >> > machine_kexec >> > >> > So maybe we need to explore doing some or all of device_shutdown() in >> > the crash_kexec() path as well as in the kernel_kexec() path. >> >> The problem is that if the machine crashed anything you try to attempt >> before starting the crash kernel is reducing the chance that the crash >> kernel actually starts. > > Right. > >> Is there something at the root bridge level which allows to tell the >> underlying busses to shut up, reset or go into a defined state? That >> might avoid chasing lists which might be already unreliable. > > Maybe we need some kind of crash_device_shutdown() that does the > minimal thing to protect the kdump kernel from devices. The kdump kernel does not use any memory the original kernel uses. Which should be a minimal and fairly robust level of protection until the device drivers can be loaded and get ahold of things. > The programming model for conventional PCI host bridges and PCIe Root > Complexes is device-specific since they're outside the PCI domain. > There probably *are* ways to do those things, but you would need a > native host bridge driver or something like an ACPI method. I'm not > aware of an ACPI way to do this, but I added Rafael in case he is. > > A crash_device_shutdown() could do something at the host bridge level > if that's possible, or reset/disable bus mastering/disable MSI/etc on > individual PCI devices if necessary. Unless I am confused DMA'ing to memory that is not already in use is completely broken wether or not you are using the kdump kernel. Eric