Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201115100623.257293-1-martin.blumenstingl@googlemail.com> <20201115155753.GC1701029@lunn.ch>
In-Reply-To: <20201115155753.GC1701029@lunn.ch>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sun, 15 Nov 2020 17:58:52 +0100
Message-ID: <CAFBinCA8T6hcdkt72g_HRRuoaUzfb28C0C5feJL+BCSf6YsRTw@mail.gmail.com>
Subject: Re: [PATCH] net: lantiq: Wait for the GPHY firmware to be ready
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Hauke Mehrtens <hauke@hauke-m.de>, netdev@vger.kernel.org,
        vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andrew,

On Sun, Nov 15, 2020 at 4:57 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > Add a 300ms delay after initializing all GPHYs to ensure that the GPHY
> > firmware had enough time to initialize and to appear on the MDIO bus.
> > Unfortunately there is no (known) documentation on what the minimum time
> > to wait after releasing the reset on an internal PHY so play safe and
> > take the one for the external variant. Only wait after the last GPHY
> > firmware is loaded to not slow down the initialization too much (
> > xRX200 has two GPHYs but newer SoCs have at least three GPHYs).
>
> Hi Martin
>
> Could this be moved into gswip_gphy_fw_list() where the actual
> firmware download happens?
>
> To me that seems like the more logical place.
good point, that's closer to the loop over all GPHY instances.
I've taken care of it in v2 - many thanks!


Best regards,
Martin