Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2579010pxb; Sun, 15 Nov 2020 09:45:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFKEnQR1OYxxH+hptbbTEaAS7Jk09Vh/f3BoU93N+QDy7JoaJ/Yd9d/yHOsUa+EjN2h6af X-Received: by 2002:a17:906:c312:: with SMTP id s18mr11109098ejz.185.1605462300861; Sun, 15 Nov 2020 09:45:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605462300; cv=none; d=google.com; s=arc-20160816; b=nvS8vgVszaw6n/hn8rWC9qBzDoOOedZ5kjSMFpshk0PXspeDfuYmVmu1y/h2w2tTzP II/3VIxAAEo6AoVndoJ7jUGBbhIQUXrKNGAEmKyK57UavmXXO1Yom7k08HpmCWFYIAUI +qGd2CVBpLEHaAZjFl7Zx7wVEQBl7enUqrfLTrLfu9HuowFn+1ICoRANo6jhTyNi5wDe nckPyGBtcTs4bcoixPdzCT5KvTvFYp82oMXbIxOzBw7u1ag1A2Zqt4y97lAmXtZaBRao xdnUOkA/PeIj2cgXoPPUQf0luzBkGGTU3fr9X2MJ/gOZ1qpCov4rVJ6Asz7P1KzOaeGI cBMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7ZhWNdmrv7uNC+shuTB5UrdMpVq8cOfsO/67ny1dABo=; b=lC9Z5R42b+WJjcKHonEgZv8jn9N78JUxBnkdIuVfRPqhSDKgY5AlI4eRWxs8hkz4J6 0OzxCYAKz71c0bTLWTqyHYnINQ4ogr9qN2Y5uD7VgwibSZiRvs1m0QW+WzC81CWcsL8P ynEMTwvw5GeyHfq179STN7O7CrFoesUwp4D1YhR63rCqSZ5NHkDMYdAy/N3A3R+6F36B s+qQwB7X0wAVdbuM6iIv9Dv944IL2wbLDe80h7oJiEkvdwcuLLrDo5NenUv878Y7nVa5 xJtIYfQoUBpzrDqas8uzUwQBt3Mp2dD4M0mdMuromIjdUGl9g20ZSy78Q9G41Q0fHctI uMCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=GKe8HtSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y63si3096461ede.581.2020.11.15.09.44.34; Sun, 15 Nov 2020 09:45:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=GKe8HtSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgKOQ5H (ORCPT + 99 others); Sun, 15 Nov 2020 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726704AbgKOQ5H (ORCPT ); Sun, 15 Nov 2020 11:57:07 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFAD2C0613D1 for ; Sun, 15 Nov 2020 08:57:05 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id y16so17079350ljk.1 for ; Sun, 15 Nov 2020 08:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7ZhWNdmrv7uNC+shuTB5UrdMpVq8cOfsO/67ny1dABo=; b=GKe8HtSGVpql7itwBeLIkBdzeQTDlLA/NMjuNvTbYEKWXB7yyVUDwFWl9MTbBscdEJ hObKcjWJK90+BTLO+zgzmCcH+qCmtS9aZD909pSoyW/0/+CSK0ggGgVgQQGW5k7uiBQQ 9/PazKzHsYQiacJMrzhtp0dCF64qWviUt14wA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7ZhWNdmrv7uNC+shuTB5UrdMpVq8cOfsO/67ny1dABo=; b=VsazhAzqXHzcB6TFTMr7bTxUJ32tU7gwxYH7TGw0L/DqX69vffJf3dzoCLX2Sngz7b wkuqQQqmPtUAkcng5ZbX5dgiTGdYLL+8TX+UgL2BtonwVaCS+uW3/hPyGDbP7SNWFdFy Z37s3lAPhE5mqVL3PjALKgg8OHc+kcCgeW33dEyCHHyyhfZ6RQUhF1q92GnUMMWGBf2T G0scd/mvw51vwkMlk1EajB2hvlrz/Gc86PnJQcWafLtZeqfnobMcB1e7K62lBV//5bRt 3fTp4WpjWlGKLWM7JLaQSOziWXsREgPRht94PEEbVTCEKe5u/Y1hpsTUwyhn8mlp0is1 py+Q== X-Gm-Message-State: AOAM530PM53R7wkdMyT4Pdhd8j7yMQkvOXFnNOFou00KgZHwtsruwevB JX5ykXLgZc4WSROtlt++bGhRwkm9+78S/A== X-Received: by 2002:a2e:86d3:: with SMTP id n19mr4974587ljj.194.1605459423931; Sun, 15 Nov 2020 08:57:03 -0800 (PST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id n186sm2380519lfa.271.2020.11.15.08.57.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Nov 2020 08:57:01 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id a9so20449204lfh.2 for ; Sun, 15 Nov 2020 08:57:00 -0800 (PST) X-Received: by 2002:a19:7f55:: with SMTP id a82mr4592052lfd.603.1605459420530; Sun, 15 Nov 2020 08:57:00 -0800 (PST) MIME-Version: 1.0 References: <20201111222116.GA919131@ZenIV.linux.org.uk> <20201113235453.GA227700@ubuntu-m3-large-x86> <20201114011754.GL3576660@ZenIV.linux.org.uk> <20201114030124.GA236@Ryzen-9-3900X.localdomain> <20201114035453.GM3576660@ZenIV.linux.org.uk> <20201114041420.GA231@Ryzen-9-3900X.localdomain> <20201114055048.GN3576660@ZenIV.linux.org.uk> <20201114061934.GA658@Ryzen-9-3900X.localdomain> <20201114070025.GO3576660@ZenIV.linux.org.uk> <20201114205000.GP3576660@ZenIV.linux.org.uk> <20201115155355.GR3576660@ZenIV.linux.org.uk> In-Reply-To: <20201115155355.GR3576660@ZenIV.linux.org.uk> From: Linus Torvalds Date: Sun, 15 Nov 2020 08:56:44 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] seq_file: add seq_read_iter To: Al Viro Cc: Nathan Chancellor , Christoph Hellwig , Greg KH , Alexey Dobriyan , linux-fsdevel , Linux Kernel Mailing List , kys@microsoft.com, haiyangz@microsoft.com, Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 15, 2020 at 7:54 AM Al Viro wrote: > > OK, I think I understand what's going on. Could you check if > reverting the variant in -next and applying the following instead > fixes what you are seeing? Side note: if this ends up working, can you add a lot of comments about this thing (both in the code and the commit message)? It confused both Christoph and me, and clearly you were stumped too. That's not a great sign. Linus