Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2602620pxb;
        Sun, 15 Nov 2020 10:39:35 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxczldcyEuanoASTfe5o+YuBRzbO1nHTNBDUEG1Sug5jiyWPITMbrLai1vxufjb22bdbPUa
X-Received: by 2002:a17:906:8c6:: with SMTP id o6mr10964504eje.230.1605465574863;
        Sun, 15 Nov 2020 10:39:34 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605465574; cv=none;
        d=google.com; s=arc-20160816;
        b=Zm/iNNSrGmeHPqYrg6VING/7Yg5UwdrHXWXAMtvwqexbuzkpug3uZwXDqzvgBXWcRi
         A0oe/OjNROF1mhVpTn9fE87XHrB6IBkxWs9uLAZdCBzJTT+Up81J7Oaqt+jfjR72y15v
         ewlIZiVGvZPa1hTMnq1FBsvfHHRN5wJG73gPwKo3GEz3Iuq4AAoyKjDwdFjXYjo0RyJ2
         Ev1ssUK5nZdEzDRT3L9eIde0tL6/gA/Foj5Er9FuN7ZFZEGlw/2JfiWSm15CpKsEwCCD
         fzpFOy2+IQR4S6e3Drq3Hee8YTxm378BlbicOBJFcqNXVtRUqktiNk/W4FfTIpjhfxn1
         aaEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from;
        bh=anm5dflcALDEl10nSUL87cp/zivIAPJR1id9Mr69p9o=;
        b=bpMPm5dpio+wdSZRW03wWMy/Aq0OMvPMcY5cPpEuTOtblOfucFoFYhEO/36UNe4dxD
         XcluRrYX8BI085jZbd8UmtP5qVhjBhjQfZ4VP7zGCl6vFCVCN4ytUa1D3k5J3ixqa7lc
         W5tZqhmXMDxpKFNAGdZW2nBzWU1bv0GJO0wS+xzFzRHqzQ+Nue/jyvRXe/HGB3RRWZ22
         O6Sy+q9XQQzqKFEFeoVcXd59ldgJxN8JCL/uinWeT7fUxeQdvlMUdTjiowvmS9CXePGJ
         nfJLhYtq691MeVbMpB8lCPdcYJqJxdWznRKZ3IfM6P8JMUGSVs6GinX7XYa77cg3wWNX
         /C7w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=NShRjNRI;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z11si9474368ejf.614.2020.11.15.10.39.11;
        Sun, 15 Nov 2020 10:39:34 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=NShRjNRI;
       dkim=neutral (no key) header.i=@linutronix.de header.s=2020e;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727037AbgKOSfz (ORCPT <rfc822;sbrunau@gmail.com> + 99 others);
        Sun, 15 Nov 2020 13:35:55 -0500
Received: from Galois.linutronix.de ([193.142.43.55]:36400 "EHLO
        galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726741AbgKOSfz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 15 Nov 2020 13:35:55 -0500
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1605465353;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=anm5dflcALDEl10nSUL87cp/zivIAPJR1id9Mr69p9o=;
        b=NShRjNRIBCGeSMMBw8XvaSEO3XpsdNPG3ez9vkEs8dTbN0kQCSptOLXAif51Ah9fguDoVk
        7t7xeabjmh+MnGe9tmDNSrMzxu3EHAn7LIaHifs3QaBydgNFSQ3i04dEsFErJFBkCVsmEB
        mm+0Q2gHinuoAxN45TQRF9GS8mm3aVdCgOqbkUGiVpemt/1e8cLHI+j2ik1xhFLXNe/h5n
        e72eynPimqqp9+ekorJnUxwwGJnuVrtEDOTBVAFJo4yao2yrh/cXGEtRCFx8EpnM1aDmMd
        MQLFSOY7X54dFOjfVZ8tsVuEF2jJ8yTmQR5D58wSI/imKRy0OtD+OvmBsDonOQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1605465353;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=anm5dflcALDEl10nSUL87cp/zivIAPJR1id9Mr69p9o=;
        b=fOWzK/LR7JTAH7B1xOZSD4L6kGGVJZxb+FbYhM7O3wBQc7o8IjzzeMGZDPPpzubu4O/rHz
        GY705EuLYG1cBWBg==
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     mingo@redhat.com, keescook@chromium.org, arnd@arndb.de,
        luto@amacapital.net, wad@chromium.org, rostedt@goodmis.org,
        paul@paul-moore.com, eparis@redhat.com, oleg@redhat.com,
        linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, Gabriel Krisman Bertazi <krisman@collabora.com>,
        kernel@collabora.com
Subject: Re: [PATCH 04/10] seccomp: Migrate to use SYSCALL_WORK flag
In-Reply-To: <20201114032917.1205658-5-krisman@collabora.com>
References: <20201114032917.1205658-1-krisman@collabora.com> <20201114032917.1205658-5-krisman@collabora.com>
Date:   Sun, 15 Nov 2020 19:35:53 +0100
Message-ID: <87y2j28o3a.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 13 2020 at 22:29, Gabriel Krisman Bertazi wrote:
>  
> +enum syscall_work_bit {
> +	SYSCALL_WORK_SECCOMP		= 0,

enums start at 0, so why do you need an explicit assignment?

> +};
> +
> +#define _SYSCALL_WORK_SECCOMP BIT(SYSCALL_WORK_SECCOMP)

Do we really have to repeat the nonsense from TIF/_TIF in the naming
here? Can we please name this in a way which makes it obvious what is
what?

Thanks,

        tglx