Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2835316pxb; Sun, 15 Nov 2020 20:22:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8fqPFUHdk00KuKo6Z8Ct+pHeuS9ej5+HkA0jOTJpalRsViWmWpaFn0W7PA6AwXH3sfYEv X-Received: by 2002:a50:858a:: with SMTP id a10mr8846425edh.190.1605500561517; Sun, 15 Nov 2020 20:22:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605500561; cv=none; d=google.com; s=arc-20160816; b=guXRnoqujwRAud+iaAOAtlvThcSoimAeMF6Kv4URpG2S5y79XklO19WL/y+X6em8AY YL5PptnW7dGjxP1YZNChNlVJzjuzuolmswywloSPbCArSe70ffmwAqWxJqHWMFAO9BEB d94I+oxP2dstFN+oM+mZDP7RdloIxkkSH4MQdvTrMHwRFgADTWY6VutGBucalhq4yGe2 NJZjnqB5I/6RV6tiO9i7poJR6XzNTHgi/Oeza8OVoXVMZA3+V3V8P1yTq6R6JgGYUPj5 bKIf25kMnTo1QerAZjVlYPXjPDAibahmJ8bA7U/WzKV/K1vgXyF3wz3H4sg7jS5qb7Wl txgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:dkim-signature:dkim-signature; bh=L1/AgPHqizdnomLrXS0OIGSD6EAbY5ECcvh31UQ1hJQ=; b=enDD1QtQIQIszuFC3BQ7OS9FPvD4W2wuzilemoW18rWNVBplPS307ZwO71S8oVY1W8 W2pcT5rYY4sZ5cb2KQQ0vsE7+WwRhyaH9oskbi5YfG+bSjH1N2rBEKGwkRfBwb73VHs1 G8owNLjpbwJLswLsCGONpkLjorC7kJaVYAyxgmdIb8prjq3aVgmQ7XxjWwd4ukkHgui7 oSi90rvegxPqvrxGdNK+TIgCTnnVCq0wA7BuTegZj5dxnGgRnB/KVlWnqdqvq8XuxSsR NBtLN8yN3F6Q72qQdw6/Kk7A3c2wRt590aXVLc1BKABGJ17gaVys7ORtcFQi8niCzUpB WfzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=FzAvqnDB; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=pMKEAPa+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si11583790edm.62.2020.11.15.20.22.19; Sun, 15 Nov 2020 20:22:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=FzAvqnDB; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=pMKEAPa+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727042AbgKPELT (ORCPT + 99 others); Sun, 15 Nov 2020 23:11:19 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34037 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgKPELT (ORCPT ); Sun, 15 Nov 2020 23:11:19 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CBB0C5C0054; Sun, 15 Nov 2020 23:11:16 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 15 Nov 2020 23:11:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=L1/AgPHqizdnomLrXS0OIGSD6EAbY5E Ccvh31UQ1hJQ=; b=FzAvqnDBlcDPjSiXOE0YpM0321NTERJcxsExT/OH5hgXIav gGEK8B5HvIlj0RZFdyazkcarcbFqdHByITeqejOMxksowEasauDYCyHFIZhP9Bwk YYXYEfiIrmaGwb/ld0qQC4XQ9TrOtgA1hmPSV3/a8hzl39Wgr5RMnWuithc58Mqy 2lC/dTl7qZTrf/3za5lPPbiXBrQYLmcrXEccQ1MQntFDUTAtNjxNbSd6NK1Q/3wE FvlWHD+z5ekWqWAiCUamTmwA+blIWf8+NYAqReVWK9qcHzsD1b+PLFPMsD7GM+W8 yiO9xDSt5QlnGJhtqWV1dDe0yZ0ZOZkUmtNWSIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=L1/AgP HqizdnomLrXS0OIGSD6EAbY5ECcvh31UQ1hJQ=; b=pMKEAPa+Iwd4j16QUeU2Yi t3bFlSzGoM4qeHHZtNyN3XZ8NzFxwjzktTXVyFar2dbVCwZOCeUQrXeUwGpaYftd lwU+Txe4951P1pCxGqyaMp7UA6gpkhNYvA3ja0edyByvI9BhqpOrGHhm6hHAmzju g4PS8sKrLyc7ve/nxnarcKI2xBsIyVT34Jg/ULCgsfdwWM4Wg13LQbEQ1TV9IMSq ziyHVeqNyft+B6V76uWdHTxCuKpNCyxl8rnXrhClYSNtxzC77fQ4sH2f/NRcmiAz +qmkkc5Gxjb2FMZgCb8o3HewvdQDlAO6G0m0FhyAg5XhMGsPWYywxiHXUa7qyT0A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeftddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 18129E00A6; Sun, 15 Nov 2020 23:11:14 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-570-gba0a262-fm-20201106.001-gba0a2623 Mime-Version: 1.0 Message-Id: <07558590-438a-4347-820e-c117b19dac20@www.fastmail.com> In-Reply-To: <20201113100850.GA168908@mwanda> References: <20201113100850.GA168908@mwanda> Date: Mon, 16 Nov 2020 14:40:55 +1030 From: "Andrew Jeffery" To: "Dan Carpenter" , "Joel Stanley" Cc: "Tom Rix" , linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: =?UTF-8?Q?Re:_[PATCH]_soc:_aspeed:_Fix_a_reference_leak_in_aspeed=5Fsoci?= =?UTF-8?Q?nfo=5Finit()?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Nov 2020, at 20:38, Dan Carpenter wrote: > This needs to call of_node_put(np) before returning if of_iomap() fails. > > Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver") > Signed-off-by: Dan Carpenter Reviewed-by: Andrew Jeffery