Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michael Brunner <Michael.Brunner@kontron.com>
To:     "lee.jones@linaro.org" <lee.jones@linaro.org>
CC:     "linux@roeck-us.net" <linux@roeck-us.net>,
        "sameo@linux.intel.com" <sameo@linux.intel.com>,
        "mibru@gmx.de" <mibru@gmx.de>,
        "vkrasnov@dev.rtsoft.ru" <vkrasnov@dev.rtsoft.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mvanyulin@dev.rtsoft.ru" <mvanyulin@dev.rtsoft.ru>
Subject: [PATCH v3] mfd: kempld-core: Check for DMI definition before ACPI
Thread-Topic: [PATCH v3] mfd: kempld-core: Check for DMI definition before
 ACPI
Thread-Index: AQHWu+OkIu811TJCPUavMPQe+vS/Xg==
Date:   Mon, 16 Nov 2020 06:42:24 +0000
Message-ID: <ca31b0f1638d07f5c597c652ed887a3ce0f595aa.camel@kontron.com>
References: <981276386ec1b496b423b7605b7ac912884b7172.camel@kontron.com>
         <bf70506e5aeb87889b298e342f96bae0e2187102.camel@kontron.com>
In-Reply-To: <bf70506e5aeb87889b298e342f96bae0e2187102.camel@kontron.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
user-agent: Evolution 3.36.4-0ubuntu1 
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <815A32B513DF774987D951E9FBAA7706@EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 44766c39-65e7-4179-89fe-08d889fac83f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 06:42:26.5522
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jK751vGs+fZaBZkorAIF/Ru1Uf7P48TxiY22+L4ySFtRvv7Ikv17RTIwTj8CZYOoZAFjSDa3gOaHsrizm5IUg6FlAegPGfQ692fmYgsxHUA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4230
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Change the detection order to priorize DMI table entries over available
ACPI entries.

This makes it more easy for product developers to patch product specific
handling into the driver.
Furthermore it allows to simplify the implementation a bit and
especially to remove the need to force synchronous probing.

Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---

v3: Cleaned up comment, added Reviewed-by

 drivers/mfd/kempld-core.c | 24 +++---------------------
 1 file changed, 3 insertions(+), 21 deletions(-)

diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
index 2c9295953c11..ecd26271b9a4 100644
--- a/drivers/mfd/kempld-core.c
+++ b/drivers/mfd/kempld-core.c
@@ -125,7 +125,6 @@ static const struct kempld_platform_data kempld_platfor=
m_data_generic =3D {
 };
=20
 static struct platform_device *kempld_pdev;
-static bool kempld_acpi_mode;
=20
 static int kempld_create_platform_device(const struct dmi_system_id *id)
 {
@@ -501,8 +500,6 @@ static int kempld_probe(struct platform_device *pdev)
 		ret =3D kempld_get_acpi_data(pdev);
 		if (ret)
 			return ret;
-
-		kempld_acpi_mode =3D true;
 	} else if (kempld_pdev !=3D pdev) {
 		/*
 		 * The platform device we are probing is not the one we
@@ -565,7 +562,6 @@ static struct platform_driver kempld_driver =3D {
 	.driver		=3D {
 		.name	=3D "kempld",
 		.acpi_match_table =3D ACPI_PTR(kempld_acpi_table),
-		.probe_type =3D PROBE_FORCE_SYNCHRONOUS,
 	},
 	.probe		=3D kempld_probe,
 	.remove		=3D kempld_remove,
@@ -884,7 +880,6 @@ MODULE_DEVICE_TABLE(dmi, kempld_dmi_table);
 static int __init kempld_init(void)
 {
 	const struct dmi_system_id *id;
-	int ret;
=20
 	if (force_device_id[0]) {
 		for (id =3D kempld_dmi_table;
@@ -894,24 +889,11 @@ static int __init kempld_init(void)
 					break;
 		if (id->matches[0].slot =3D=3D DMI_NONE)
 			return -ENODEV;
-	}
-
-	ret =3D platform_driver_register(&kempld_driver);
-	if (ret)
-		return ret;
-
-	/*
-	 * With synchronous probing the device should already be probed now.
-	 * If no device id is forced and also no ACPI definition for the
-	 * device was found, scan DMI table as fallback.
-	 *
-	 * If drivers_autoprobing is disabled and the device is found here,
-	 * only that device can be bound manually later.
-	 */
-	if (!kempld_pdev && !kempld_acpi_mode)
+	} else {
 		dmi_check_system(kempld_dmi_table);
+	}
=20
-	return 0;
+	return platform_driver_register(&kempld_driver);
 }
=20
 static void __exit kempld_exit(void)
--=20
2.25.1