Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp2946279pxb; Mon, 16 Nov 2020 01:15:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1uI/ojUBCd+PwGSkch4awS7beullROIFhIrC4hhg2wdxZ+kvRfkyOH09mXotl8Z0o78ev X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr13585844ejz.341.1605518136233; Mon, 16 Nov 2020 01:15:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605518136; cv=none; d=google.com; s=arc-20160816; b=JASS/LBeJBVd+w8lAJeof7s2tpGyjZAzcMa9oo5m4d5/C9ETfTxyzJICthGEZigdVu 8IIYl6ptxA06jmxUjyx8ymFh93jND/SILMnQRZ060WyBqgtLtFAEzI7kxzkyJDw23wIS XMJtA/hemOBJUu4IYxgViXwVIk5pcXUGqaLNM0DGy0QOuwtlCOa1KDhBEcSk5R8p331d 6wpwYKeY/DlC+wIy/6obOI0scxljNB/748x7mky6W4X92EYcssI6uPt/YFTDB+9W0TId bPLQlBKYlGRrFZQz1IL1LmW+si21y75xItRZTxvstreTyyt+Ag5Pnmp2L3gwr1F25nAd qX6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=WDZ0CXg1yGGGY1e+ZEpaxJ8BP4ehKDc93ZgVx1cWbq4=; b=NwXzl1fquiaO0/VyZcgky0gWppgPUhgeJopkF7nnw0186P/4OiWEG+ZydGGXwuaMSS sWmgIFoaZXCpSeSGA639ASybz6ecqG3Wn5SYdogMUt+FZ4ZqtpF8QDMBhB7mgr5z2+Lg /4Gy8dLvp7nfB5TUDH3pzEYqQt9VBsv1bQoDdpR3qG7a/Ugw/0vac/45TG73EELusjOu t/Cq4fTIGvXy64kLWJz03yufgdm6lGRd3Q+bZi7wHlurHFuySo1/w6QylZtSjGkrCeeO Ivy1o8aUfznxpuoYHGE+TOwyVq/bkMBSHZFH6j/L6lL0sWucoRaGIfX1htq5wSj2Dx7A ZKXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Fa03gclw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kt22si10941937ejb.384.2020.11.16.01.15.12; Mon, 16 Nov 2020 01:15:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Fa03gclw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbgKPJLi (ORCPT + 99 others); Mon, 16 Nov 2020 04:11:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728548AbgKPJLh (ORCPT ); Mon, 16 Nov 2020 04:11:37 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92531C0613CF for ; Mon, 16 Nov 2020 01:11:37 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id p68so2190634pga.6 for ; Mon, 16 Nov 2020 01:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=WDZ0CXg1yGGGY1e+ZEpaxJ8BP4ehKDc93ZgVx1cWbq4=; b=Fa03gclw6DQdj/8PiYVlZF2lcgcpa6b7ZQ50CFbBTiKC5dPzp+8N0tKBuHXqEv94pc t5NvA46nADIWQv41ep14lcoZVlCjxH5WdvtTwYg24yi8i4Ts5e9UZfGsFL4UwqpBZ4Za zYEA+bBqVlI7WZpcqTg0FopFVLi25I/mTqRtkNB706sCFzw6pW/Fm+Hf2wdv2F7jbIQI Gs/ji/iNqoJQMyOXrz7v4L4pStyraWi2Rg4VFY8sj86Y9wzrXlFBVgGTwhdppv8wfIM1 QAIf0grkD5mAdQ2c/juJ9XF2VdhpGY+f1Azn8Qy2NHbjJ9/c5kgdvrZ4dal+/f6LxONR XNZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WDZ0CXg1yGGGY1e+ZEpaxJ8BP4ehKDc93ZgVx1cWbq4=; b=K7KdxPWv5w58izUJjHQUUSXuyHt7XaGvGyLdqPsf3DY2nCAwgzAOeoI9ypMFXjgDro Zle81HrNOAGMeoTTTsQ4elQiojelwYjBEJeyKLDdWb6rFnHzHaXz0cNM9wDDa9j3l1qD zkGh2UJkw1kSbm9zxtHLfpk0jVzXrzTw4/ICWqPi/XzIRpZ2/kzUpkGqQux4PCCoyCtq s3Ff7n9a7UYoShWL3Bclmg+fS0P++9icVyKLKK8HPc+WW3YRGXr1Mz0iOOzsQAu2PgZA GKv6sErrU9DOjGvmvl84saUEFjg+V1/Wfu19SWQ+xOXjdtsbSdIv0fr6r2JMHVGcZDgx +Rxg== X-Gm-Message-State: AOAM530enKKSBBwmlrbBvIUk3Etm7+I2Zb0M/l8khZo2enBYguw0qXhI oXBbFGHAOGRM0jFEkuqKpuMx/DMVKUVx X-Received: by 2002:a63:1d12:: with SMTP id d18mr12559140pgd.314.1605517896964; Mon, 16 Nov 2020 01:11:36 -0800 (PST) Received: from he-cluster.localdomain (67.216.221.250.16clouds.com. [67.216.221.250]) by smtp.gmail.com with ESMTPSA id s18sm15332635pgh.60.2020.11.16.01.11.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Nov 2020 01:11:36 -0800 (PST) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: kishon@ti.com, vkoul@kernel.org Cc: linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up Date: Mon, 16 Nov 2020 17:11:31 +0800 Message-Id: <1605517891-20357-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kaixu Xia The value of variable error is overwritten by the following call devm_request_threaded_irq() in phy_mdm6600_device_power_on(), actually we should return error when timed out powering up. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- v2: -directly return error when timed out powering. drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c index 5172971f4c36..2f461c0d7276 100644 --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -423,6 +423,7 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata) ddata->enabled = false; error = -ETIMEDOUT; dev_err(ddata->dev, "Timed out powering up\n"); + return error; } /* Reconfigure mode1 GPIO as input for OOB wake */ -- 2.20.0