Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201116104119.816527-1-lee.jones@linaro.org>
In-Reply-To: <20201116104119.816527-1-lee.jones@linaro.org>
From:   Jinpu Wang <jinpu.wang@cloud.ionos.com>
Date:   Mon, 16 Nov 2020 11:44:52 +0100
Message-ID: <CAMGffEkMahL5Fw6w6izwOu2wh3RqAebm9-N3KCadS2N177rLKg@mail.gmail.com>
Subject: Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 16, 2020 at 11:41 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Hasn't been used since 2009.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/scsi/pm8001/pm8001_hwi.c: In function =E2=80=98mpi_set_phys_g3_w=
ith_ssc=E2=80=99:
>  drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable =E2=80=98value=
=E2=80=99 set but not used [-Wunused-but-set-variable]
>
> Cc: Jack Wang <jinpu.wang@cloud.ionos.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Thanks Lee.
> ---
>  drivers/scsi/pm8001/pm8001_hwi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm800=
1_hwi.c
> index 2054c2b03d928..0a1e09b1cd580 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -416,7 +416,7 @@ int pm8001_bar4_shift(struct pm8001_hba_info *pm8001_=
ha, u32 shiftValue)
>  static void mpi_set_phys_g3_with_ssc(struct pm8001_hba_info *pm8001_ha,
>                                      u32 SSCbit)
>  {
> -       u32 value, offset, i;
> +       u32 offset, i;
>         unsigned long flags;
>
>  #define SAS2_SETTINGS_LOCAL_PHY_0_3_SHIFT_ADDR 0x00030000
> @@ -467,7 +467,7 @@ static void mpi_set_phys_g3_with_ssc(struct pm8001_hb=
a_info *pm8001_ha,
>         so that the written value will be 0x8090c016.
>         This will ensure only down-spreading SSC is enabled on the SPC.
>         *************************************************************/
> -       value =3D pm8001_cr32(pm8001_ha, 2, 0xd8);
> +       pm8001_cr32(pm8001_ha, 2, 0xd8);
>         pm8001_cw32(pm8001_ha, 2, 0xd8, 0x8000C016);
>
>         /*set the shifted destination address to 0x0 to avoid error opera=
tion */
> --
> 2.25.1
>