Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3013100pxb; Mon, 16 Nov 2020 03:33:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwraDfS5G+zVM7E9Z0emCJ6lrzc2pKjIPPPH/K8Rwc/p5wOxQJEXy/vRuuEt8+PRprd06Cq X-Received: by 2002:a17:907:608:: with SMTP id wp8mr6202311ejb.489.1605526389524; Mon, 16 Nov 2020 03:33:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605526389; cv=none; d=google.com; s=arc-20160816; b=rkwFTpRoU8WxykHh3MhognK/sVwBQ16NGpIRSGVrRGsUZ/w1XikdLqNxy6/StP3U6q rRh2RX205kcMZbUpXTl6f8ZS+XPRjvn5HQMK5s1wSBcVcEWx542+HuuNCubbcOrEPLkn zYcSKi1qP+6dq+7KOkhHvT6PF6Ii3DrxX2chG1RdoTSO4kto9uWdKv/K+oBIO/eFjEyd QTkegyIN6pGJN7EqYrYfbqCwrZoMv/cx1Xcd5a8dZPQuVPeJwRbMw+q7fh9YkcKa9IvF /hFrgSv5xM0Psd+lOrb4H4YMXFBN8KdLVYjGEcxKhHegosmNTGsRu1UrMpMPjOzrTplD uK2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=TtNGGRtV0p5WNgbCubhzNP+sFuTsNY+Ujk6w0tlBAac=; b=M1PQRHH83jiOSOEDBVjWBRIDBj+oSXVJmQYs3Hd2zE37fGAorkkK+dPzCm2DAvROld LsUO5voy8I7Nf0rOILh3yI1+rOafN7uXZRZ/za7+gRc0QUUUDeZnayHdkHk8/A7J4tiw 5rGBTDqXeYA5wEOwis19isXvmfUzLKqw3p1lD6KTySnPIDIXx4ZHmCUTZnjBfX+DAwr5 LcOf+mT/5LrDyBYuHaGtQGfn6LK1CcyjFB/d3Fi5+8JY/rj2d6sZeO2rHeRRsRt60ozC jzuvIFAFsXwYnP+IeVK0uLra3VZElOAvUi0ePXYrK4eKymxaPUuSZsm52Om3t+ogf+AN uAdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org ([23.128.96.18]) by mx.google.com with ESMTP id b20si11768659edv.300.2020.11.16.03.32.46; Mon, 16 Nov 2020 03:33:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729110AbgKPL20 (ORCPT + 99 others); Mon, 16 Nov 2020 06:28:26 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:34592 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgKPL20 (ORCPT ); Mon, 16 Nov 2020 06:28:26 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kecgK-0000QM-Ro; Mon, 16 Nov 2020 11:28:24 +0000 Subject: Re: [PATCH][next] drm/atomic: avoid null pointer dereference on pointer crtc To: Simon Ser Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sam Ravnborg , "dri-devel@lists.freedesktop.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20201116110316.269934-1-colin.king@canonical.com> From: Colin Ian King Message-ID: Date: Mon, 16 Nov 2020 11:28:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/2020 11:08, Simon Ser wrote: > On Monday, November 16, 2020 12:03 PM, Colin King wrote: > >> From: Colin Ian King colin.king@canonical.com >> >> Since moving to the new debug helper functions we now have a debug message >> that dereferences crtc to print a kernel debug message when crtc is null >> and so this debug message will now cause a null pointer dereference. Since >> this is a debug message it probably is just simplest to fix this by just >> removing the debug message altogether. > > NACK. This removes the log altogether instead of fixing it. > > A fix has already been pushed to drm-misc-next: 0003b687ee6d ("drm: fix > oops in drm_atomic_set_crtc_for_connector"). > Good to see this has already been fixed. Thanks. Colin