Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Chen Zhou <chenzhou10@huawei.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "weiyongjun1@huawei.com" <weiyongjun1@huawei.com>,
        "jun.li@freescale.com" <jun.li@freescale.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH v2] usb: gadget: mass_storage: fix error return code in
 msg_bind()
Thread-Topic: [PATCH v2] usb: gadget: mass_storage: fix error return code in
 msg_bind()
Thread-Index: AQHWuPqsLIOnAtmxwUipVxtESKIpeqnKz+IA
Date:   Mon, 16 Nov 2020 14:01:33 +0000
Message-ID: <20201116140104.GG28313@b29397-desktop>
References: <20201112135423.89536-1-chenzhou10@huawei.com>
In-Reply-To: <20201112135423.89536-1-chenzhou10@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93BBCD88BDED4349B2F61D504CDF2BEC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 59ca0937-133b-455b-35e9-08d88a381fef
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 14:01:33.0591
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lAFXCUpN3WnPZQeOiL78TjfcvU5DKjz+sX2JBJtOY6lFl5ecDq6O5C7M42ZKTgrrYsf0tGzQ+Em5TR1H+sAB8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6027
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-11-12 21:54:23, Chen Zhou wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function msg_bind(), as done elsewhere in this
> function.
>=20
> Fixes: d86788979761 ("usb: gadget: mass_storage: allocate and init otg de=
scriptor by otg capabilities")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>

Reviewed-by: Peter Chen <peter.chen@nxp.com>

Peter
> ---
>  drivers/usb/gadget/legacy/mass_storage.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/gadget/legacy/mass_storage.c b/drivers/usb/gadge=
t/legacy/mass_storage.c
> index 9ed22c5fb7fe..ac1741126619 100644
> --- a/drivers/usb/gadget/legacy/mass_storage.c
> +++ b/drivers/usb/gadget/legacy/mass_storage.c
> @@ -175,8 +175,10 @@ static int msg_bind(struct usb_composite_dev *cdev)
>  		struct usb_descriptor_header *usb_desc;
> =20
>  		usb_desc =3D usb_otg_descriptor_alloc(cdev->gadget);
> -		if (!usb_desc)
> +		if (!usb_desc) {
> +			status =3D -ENOMEM;
>  			goto fail_string_ids;
> +		}
>  		usb_otg_descriptor_init(cdev->gadget, usb_desc);
>  		otg_desc[0] =3D usb_desc;
>  		otg_desc[1] =3D NULL;
> --=20
> 2.20.1
>=20

--=20

Thanks,
Peter Chen=