Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3136042pxb; Mon, 16 Nov 2020 06:45:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcpAmHPteCVAx2d73qqkftNSJecZcmdTVmbtX2zi7n9veSa5TU6IU0YNes4x933xmpIWCE X-Received: by 2002:a50:f40a:: with SMTP id r10mr15944326edm.229.1605537945928; Mon, 16 Nov 2020 06:45:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605537945; cv=none; d=google.com; s=arc-20160816; b=D3N+dh0zvo5tKpxXxCeYjPGKuDy2xP1DQs4ZJ7NNffepimNhgiB32HuVrVwmiqCZIa XNUAqZtBtcggNP+xVtJ88Pjum6QshwRppzyJiQ2jXJ/GJBvj9+z9quMEJ3Qr5rAaCDzn oXpv+gtJpgOw3n6Bz0HJ+MHOGIF+bwXHiNofyp6ml8vFmtnqnI+s8LL/YcI7Wo20c1zW 6/hQuzR39laXxon3ZdBe5g/vwo/bC8sMHVk94c9ntaJX+eTarNstRHX9tNLq9ugRgb7Q TrHjS+9sVXRDP6d2e9k7be6exNb7eg3T4Ma3Rw9Xk3wsRPvWzwnw2Qta8RFM5VkKL+0B FUvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=2lJRMgXZxwPjHrpBbJXCv+2QZcN9SyyOf2icTFPFyww=; b=yhCfxXe9gXbi5Kcu56M9hCgReB851IMPaW00bJQOeUNxv3wtSXJoncbknIGqkE2MV7 BmSXjfXMHQUVSS+fRfm0zTQn6RnJ7YZDAd73J2Y40WJQU1HfdFRk4nUgRJ5AcdDljzH7 eN/7jsXQPEkSTKrihcghUKj2ozGtHW/Kskyw03uhFqOuubdUr5docmKPIl6emeRuhecs bmVS+89NjIAjZiphKkImvcUcdAaKhHD/lAPoF76TinbL9e2O95BenW6HXXx4FlDo9AX1 4Fb8DASIdUJVv8kyG4SmVpYuIF18tXfDFwj1g3X+whox43Puyxdem01hx0lziLZsPNcR xZhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq40si4975998ejc.462.2020.11.16.06.45.15; Mon, 16 Nov 2020 06:45:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730266AbgKPOmq (ORCPT + 99 others); Mon, 16 Nov 2020 09:42:46 -0500 Received: from mga18.intel.com ([134.134.136.126]:23726 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730250AbgKPOmp (ORCPT ); Mon, 16 Nov 2020 09:42:45 -0500 IronPort-SDR: orcUgW/H4SHtHkjt5ZN4mbnN0nqGorYNUlgxSFsehrQaONAt2JbLO/cl0bu+ylf+OHi5vNi65h u/h7l3ehjVtA== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="158530933" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="158530933" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 06:42:44 -0800 IronPort-SDR: mdZvDNgUeCjsSvi0aHbg0soGnpP3Z13ut53o5aklNIirNIucTupKd6nx4VlYduP2wmEOirqGP/ Iq1me7rOn9zA== X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="533435220" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 06:42:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kefjL-0075SL-DV; Mon, 16 Nov 2020 16:43:43 +0200 Date: Mon, 16 Nov 2020 16:43:43 +0200 From: Andy Shevchenko To: Claudius Heine Cc: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Henning Schild , Johannes Hahn Subject: Re: [PATCH v2 1/3] rtc: rx6110: add i2c support Message-ID: <20201116144343.GA1689012@smile.fi.intel.com> References: <20201112130734.331094-1-ch@denx.de> <20201112130734.331094-2-ch@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112130734.331094-2-ch@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 02:07:32PM +0100, Claudius Heine wrote: > The RX6110 also supports I2C, so this patch adds support for it to the > driver. > > This also renames the SPI specific functions and variables to include > `_spi_` in their names. As practice shows this is not the best approach. Can you ratqer split it to three modules: core, spi, i2c like it's done in many other cases (esp. IIO)? In Kconfig you just leave same option with two additional ones like config ..._SPI tristate default SPI_MASTER depends on SPI_MASTER config ..._I2C tristate default I2C depends on I2C -- With Best Regards, Andy Shevchenko