Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Lc1Kinf5u41R787EDdjstzAdkkYcbRhstwfwVWISYQKDwWW3YuCloAa3JklNj6virHMqiBa2ao
 iJYcppiuWqEA==
IronPort-SDR: 4D3M3GrfcY3OGBuGYQE/mG5d7U2ks71wToYrCxIwJ+7269hMa00wyh2I1L3cyWPO78+4X5FXIR
 b9MEk69W5Jiw==
Date:   Mon, 16 Nov 2020 06:53:55 -0800
From:   Andi Kleen <ak@linux.intel.com>
To:     Ian Rogers <irogers@google.com>
Cc:     "Jin, Yao" <yao.jin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel <Linux-kernel@vger.kernel.org>,
        "Liang, Kan" <kan.liang@intel.com>, "Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Message-ID: <20201116145355.GU894261@tassilo.jf.intel.com>
References: <20201104015102.30363-1-yao.jin@linux.intel.com>
 <20201106030018.GA359712@google.com>
 <93fae76f-ce2b-ab0b-3ae9-cc9a2b4cbaec@linux.intel.com>
 <CAM9d7chhrYh1hmHkw8NKkwEHDoU0q2ArpOj3NGm0_RiQ7eSuxQ@mail.gmail.com>
 <38be0597-7f93-0aa1-b4c5-3c7f23b74f13@linux.intel.com>
 <20201115133558.GN894261@tassilo.jf.intel.com>
 <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>
Precedence: bulk

>    I'd prefer if we could make a copy of these scripts into the kernel tree
>    along with the data files from:
>    https://download.01.org/perfmon/

FWIW I originally tried this to include the raw JSON files, but Ingo objected
and wanted the files to be split up[1] and avoiding redundant headers. 
That's why we ended up with the "compiled" format.

[1] https://lkml.org/lkml/2015/5/28/336

>    Having a generated file that can't be edited, reviewed, .. I also worry
>    that if/when we change the json format then event-converter-for-linux-perf
>    will need to support a multitude of perf versions.

You mean for backports? The assumption was that perf backports would backport
any perf changes for new formats too.

In general I generally discourage any perf tools backport, people should just use
a new version of the perf tool on old kernels.

In principle the scripts could be included, but without the raw files it would
be somewhat pointless.

-andi