Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3217948pxb; Mon, 16 Nov 2020 08:42:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJyHhEmWOIifud33u6HTR0X7S+cYE4OOJHwYKGUKK6NXtS/KmW9o68WKHgQUjz2cWbFc7O X-Received: by 2002:a17:906:f98d:: with SMTP id li13mr15045748ejb.307.1605544920832; Mon, 16 Nov 2020 08:42:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605544920; cv=none; d=google.com; s=arc-20160816; b=J4Xnxke8i87f/uZEo4oom+vtDtG/f8WnDzPw0AXwhDvngge3aM0sYmnvhq7mDhmDFg qnazaPYlz2LYWcTO3lns6yQ70rlM0JHQnzZSOLhiHWif5OXVTvi2nOVrgjKv6md9Oixe /xlX5D7DVN5fvdVIubmso0V+laIxAClHvYvL7kvX5QaI6zfXH0psrhaLq02Sbov4Sscj tMX0LTCqUVeJvJeK9VKCFEmehU7Jca0C4xa0avOPPtcTkjYVTTfzB9LU/F37h0bHTJ8t uwe9jbmkyAcUauZyMK42+WRqSyyTP2iqeob/TW4USUP4bi+Kw2AGrvUeExA4J9/ZcG5a hVMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/M9t61KOqi1MYTJyagjw+b8PgJisejej65ZgJ6XoswQ=; b=kqjxmhH6dP1b/Ft3wmQIeywWWgUU1VUIYyBX3bElo4AedqD5bFm4n0qgnuJK6BebDp o4VIHSarbcyiJkUGw6YBwKl2uOfE51+fwgntffEL8QDFZ6c9sfdwy13mWxyD2OeiK81n efASnqK37Dp0ka5oA/41nhxhbQh3ucMMXommqB2nAfHxcdcInyOiMAtPdiJgh6WVf09V BueqVU4qfbl2fOf+EFtFJmiG71iOuUl+zv6RGqgHqLqK6YvDGqrzMyDn66zHIWFGv8k9 URGQhYKRsDT0zowa0dXfoxwXvlYy2yaS1Mbf6b5zsPcx47xQjs7AHj6HSmHlIqFvLWNZ 9hYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=c3SQUeMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn26si13042939ejc.739.2020.11.16.08.41.37; Mon, 16 Nov 2020 08:42:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=c3SQUeMi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732196AbgKPQjT (ORCPT + 99 others); Mon, 16 Nov 2020 11:39:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730490AbgKPQjT (ORCPT ); Mon, 16 Nov 2020 11:39:19 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15258C0613CF; Mon, 16 Nov 2020 08:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/M9t61KOqi1MYTJyagjw+b8PgJisejej65ZgJ6XoswQ=; b=c3SQUeMiZ9CED8cEqQQLM9KkUB 6i+1ST71hFHKpE43MqROlgG6q/v+fN1xdBwUbfi7kGuSWOnKW7HquppFhlrUpXMC+x8MSeYgi37UR 9LBBGdeyY/8nwkhxPmFbQLe3jkmev9R6j1sWhUHZEyU9UaV1S+L6ALECNoE2Wm/h8QGJB/o+BgGiE Xjx+vMS2QqGgXaI/0peIaY40ntlEgZDAxRq4lKfHUwtxzXj/E4/DyQiLGhY8bOZmuPqssbbDTEQWH r9/u+8JGT/mB/b6VS7gAiB4jrKn9T34MMvHs6orCNCV+UONq4274s0z2zudslnnUolT2zBOWTklf2 1erZnp/Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kehX1-0005Cd-9h; Mon, 16 Nov 2020 16:39:07 +0000 Date: Mon, 16 Nov 2020 16:39:07 +0000 From: Christoph Hellwig To: Arnaud POULIQUEN Cc: Christoph Hellwig , Alexander Lobakin , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Suman Anna , Mathieu Poirier , Bjorn Andersson , Ohad Ben-Cohen , "Michael S. Tsirkin" , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial Message-ID: <20201116163907.GA19209@infradead.org> References: <20201116091950.GA30524@infradead.org> <20201116162844.GB16619@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116162844.GB16619@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Btw, I also still don't understand why remoteproc is using dma_declare_coherent_memory to start with. The virtio code has exactly one call to dma_alloc_coherent vring_alloc_queue, a function that already switches between two different allocators. Why can't we just add a third allocator specifically for these remoteproc memory carveouts and bypass dma_declare_coherent_memory entirely?