Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932322AbWHWDyG (ORCPT ); Tue, 22 Aug 2006 23:54:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932324AbWHWDyG (ORCPT ); Tue, 22 Aug 2006 23:54:06 -0400 Received: from smtp.osdl.org ([65.172.181.4]:5039 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932322AbWHWDyD (ORCPT ); Tue, 22 Aug 2006 23:54:03 -0400 Date: Tue, 22 Aug 2006 20:53:59 -0700 From: Andrew Morton To: Josh Triplett Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make spinlock/rwlock annotations more accurate by using parameters, not types Message-Id: <20060822205359.5a06dcde.akpm@osdl.org> In-Reply-To: <1156294298.4510.5.camel@josh-work.beaverton.ibm.com> References: <1156294298.4510.5.camel@josh-work.beaverton.ibm.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 17 On Tue, 22 Aug 2006 17:51:38 -0700 Josh Triplett wrote: > The lock annotations used on spinlocks and rwlocks currently use > __{acquires,releases}(spinlock_t) and __{acquires,releases}(rwlock_t), > respectively. This loses the information of which lock actually got acquired > or released, and assumes a different type for the parameter of __acquires and > __releases than the rest of the kernel. While the current implementations of > __acquires and __releases throw away their argument, this will not always > remain the case. It won't? Why, what will happen? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/