Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201026144943.30821-1-grzegorz.jaszczyk@linaro.org> <a1a787b2-efac-3baf-2a3c-ba135b8b32d0@ti.com>
In-Reply-To: <a1a787b2-efac-3baf-2a3c-ba135b8b32d0@ti.com>
From:   Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Date:   Mon, 16 Nov 2020 18:17:37 +0100
Message-ID: <CAMxfBF4SJsPYZqr5nB4puQAFPGWh6X-L6ty027dAJgdUvy9EZw@mail.gmail.com>
Subject: Re: [PATCH] soc: ti: pruss: Remove wrong check against
 *get_match_data return value
To:     Suman Anna <s-anna@ti.com>
Cc:     Santosh Shilimkar <ssantosh@kernel.org>,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        "Bajjuri, Praneeth" <praneeth@ti.com>, tony@atomide.com,
        Wei Yongjun <weiyongjun1@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Suman,

On Tue, 10 Nov 2020 at 21:43, Suman Anna <s-anna@ti.com> wrote:
>
> Hi Greg,
>
> On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote:
> > Since the of_device_get_match_data() doesn't return error code, remove
> > wrong IS_ERR test. Proper check against NULL pointer is already done
> > later before usage: if (data && data->...).
> >
> > Additionally, proceeding with empty device data is valid (e.g. in case
> > of "ti,am3356-pruss").
> >
> > Reported-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Please add the appropriate Fixes: tag.
>
> And prefer %s/Remove/Fix/ in patch title.

Sure.

>
> With that,
> Acked-by: Suman Anna <s-anna@ti.com>

Thank you, I will post v2 with all improvements soon.
Best regards,
Grzegorz