Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3281252pxb; Mon, 16 Nov 2020 10:14:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwk3NwY4kOxReK4hUufoAnyfOmYb3rW+DENa+st3a3+7byhNeO2VFEsdXtMfwjHix44mLln X-Received: by 2002:a17:906:6dd6:: with SMTP id j22mr7152994ejt.255.1605550458625; Mon, 16 Nov 2020 10:14:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605550458; cv=none; d=google.com; s=arc-20160816; b=CytzNZ8dfYTbuikDGOe2LTMVzgKX2/ScmqIegmMKdhil720vMV1nOCd5xXCqHeFTsn aBmtvsX7ucMF6Z1caPkdTeJqFieawejjvQOCDUDNRQE5gdP8jaSKH5HUk4+h+ofHLoFt 7Qi5wyD1bhql0b7KGbSB0iauf1ZoWc1PmcxJBog/rSlesrYmqItuzKqGS/wgcUXl7RmE aF9Hw9wwHkN8qLPoHGV1LtEDGKtKAXzY8Cn9dyFx14UmgAYWqfYyx/dDU8Wo7h9s8NZa 4OE3/tMFWjQOda2X7ny+CsoX28KJIvA5+2mSNiULIu8eog/KKSW/JpI6kkx5yuMvxyUS qQJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=+uC7Y26/uXFxZx87Xoqi883QbKzE1gBD6NslXGIAf+Y=; b=CqjjqwZ2txmnCaEm9thVL5ovAAobbYe41tE2hi7eUXUqyH0aiOOacKxs4AKUasKMXk Z3NrRYMCiB/KCbDjQ78c02tMKpto8MuZthsdkXG8XPq2dt9R76qk3LGC+ut8AX11n3F8 l+efwa47NUHva59Oor22qtR5dCIb/D07fJxsEB78LHPsaYCMLs738RqDxbFhwXPkf2Y6 NWDSIxXD/LsPSbdmazAxjKR6X2utFKpdpIScybcIm8idfyqMb26X/JPVbS2BJn3+h9E3 eUNL60udXfs6vMiopM82gYT5eK93PoM+Fcz8vO0W/clzaHhbwRTWW5AmHjNky45AkY3J vJ8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zxnyyoC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si13463944edp.196.2020.11.16.10.13.54; Mon, 16 Nov 2020 10:14:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=zxnyyoC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730876AbgKPSKk (ORCPT + 99 others); Mon, 16 Nov 2020 13:10:40 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:45966 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730379AbgKPSKj (ORCPT ); Mon, 16 Nov 2020 13:10:39 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AGIABEY108138; Mon, 16 Nov 2020 18:10:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=+uC7Y26/uXFxZx87Xoqi883QbKzE1gBD6NslXGIAf+Y=; b=zxnyyoC+JA5RXg7U6ZwW8wDj2Cdv8wSgEOkfGZOuII7TPueriQ0qzkm852jgHTHsQIQn PaqX48MHIGzGVjUCDKFUYHvBOFlAKLzTqO+9lDvHbjHsUBiZ69HGcwCWEEpeMEjHdk1E hQo86i1VQPf+xyUtWbVSoJ8ek2kdCpfgwBXokDKuuluY0hCkGpBoSJ72Yn/2fsr9usYz lkE8it1SCMKaVJUYVAhR6NlFe/yPKZ/wcmpjtcu12I5aCv6S1YShdS1MTs5gH1sXfhZv P9+0+6RK2oodWKrndduxbFFiwsTN/HrS6pIp+Ln7xAv8bIEIkz1oXkFLJIyc4suq70Nx Tw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 34t4rapk5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Nov 2020 18:10:11 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AGI0Wmh123257; Mon, 16 Nov 2020 18:08:06 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 34ts5v0n04-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Nov 2020 18:08:06 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AGI81kh009056; Mon, 16 Nov 2020 18:08:02 GMT Received: from localhost.localdomain (/92.157.91.83) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Nov 2020 10:08:01 -0800 Subject: Re: [RFC][PATCH v2 12/21] x86/pti: Use PTI stack instead of trampoline stack To: Andy Lutomirski Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , X86 ML , Dave Hansen , Peter Zijlstra , LKML , Tom Lendacky , Joerg Roedel , Konrad Rzeszutek Wilk , jan.setjeeilers@oracle.com, Junaid Shahid , oweisse@google.com, Mike Rapoport , Alexander Graf , mgross@linux.intel.com, kuzuno@gmail.com References: <20201116144757.1920077-1-alexandre.chartre@oracle.com> <20201116144757.1920077-13-alexandre.chartre@oracle.com> From: Alexandre Chartre Message-ID: Date: Mon, 16 Nov 2020 19:10:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011160106 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9807 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011160107 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/20 5:57 PM, Andy Lutomirski wrote: > On Mon, Nov 16, 2020 at 6:47 AM Alexandre Chartre > wrote: >> >> When entering the kernel from userland, use the per-task PTI stack >> instead of the per-cpu trampoline stack. Like the trampoline stack, >> the PTI stack is mapped both in the kernel and in the user page-table. >> Using a per-task stack which is mapped into the kernel and the user >> page-table instead of a per-cpu stack will allow executing more code >> before switching to the kernel stack and to the kernel page-table. > > Why? When executing more code in the kernel, we are likely to reach a point where we need to sleep while we are using the user page-table, so we need to be using a per-thread stack. > I can't immediately evaluate how nasty the page table setup is because > it's not in this patch. The page-table is the regular page-table as introduced by PTI. It is just augmented with a few additional mapping which are in patch 11 (x86/pti: Extend PTI user mappings). > But AFAICS the only thing that this enables is sleeping with user pagetables. That's precisely the point, it allows to sleep with the user page-table. > Do we really need to do that? Actually, probably not with this particular patchset, because I do the page-table switch at the very beginning and end of the C handler. I had some code where I moved the page-table switch deeper in the kernel handler where you definitively can sleep (for example, if you switch back to the user page-table before exit_to_user_mode_prepare()). So a first step should probably be to not introduce the per-task PTI trampoline stack, and stick with the existing trampoline stack. The per-task PTI trampoline stack can be introduced later when the page-table switch is moved deeper in the C handler and we can effectively sleep while using the user page-table. alex.