Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     <linux-mm@kvack.org>, Matthew Wilcox <willy@infradead.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        Yang Shi <shy828301@gmail.com>,
        "Michal Hocko" <mhocko@kernel.org>,
        John Hubbard <jhubbard@nvidia.com>,
        "Ralph Campbell" <rcampbell@nvidia.com>,
        David Nellans <dnellans@nvidia.com>
Subject: Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any
 order in split page_owner.
Date:   Mon, 16 Nov 2020 12:27:23 -0500
Message-ID: <DFE4138B-FD60-431A-84C4-36FF67B8B7D2@nvidia.com>
In-Reply-To: <20201116162519.f4n445yku3dp2fhw@box>
References: <20201111204008.21332-1-zi.yan@sent.com>
 <20201111204008.21332-4-zi.yan@sent.com>
 <20201116162519.f4n445yku3dp2fhw@box>
MIME-Version: 1.0
Content-Type: multipart/signed;
        boundary="=_MailMate_F877A42F-87E8-4D50-BD05-6C2E64926FC5_=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=_MailMate_F877A42F-87E8-4D50-BD05-6C2E64926FC5_=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 16 Nov 2020, at 11:25, Kirill A. Shutemov wrote:

> On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> It adds a new_order parameter to set new page order in page owner.
>> It prepares for upcoming changes to support split huge page to any low=
er
>> order.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>  include/linux/page_owner.h | 7 ++++---
>>  mm/huge_memory.c           | 2 +-
>>  mm/page_alloc.c            | 2 +-
>>  mm/page_owner.c            | 6 +++---
>>  4 files changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h
>> index 3468794f83d2..215cbb159568 100644
>> --- a/include/linux/page_owner.h
>> +++ b/include/linux/page_owner.h
>> @@ -31,10 +31,11 @@ static inline void set_page_owner(struct page *pag=
e,
>>  		__set_page_owner(page, order, gfp_mask);
>>  }
>>
>> -static inline void split_page_owner(struct page *page, unsigned int n=
r)
>> +static inline void split_page_owner(struct page *page, unsigned int n=
r,
>> +			unsigned int new_order)
>>  {
>>  	if (static_branch_unlikely(&page_owner_inited))
>> -		__split_page_owner(page, nr);
>> +		__split_page_owner(page, nr, new_order);
>
> Hm. Where do you correct __split_page_owner() declaration. I don't see =
it.

I missed it. Will add it. Thanks.

=E2=80=94
Best Regards,
Yan Zi

--=_MailMate_F877A42F-87E8-4D50-BD05-6C2E64926FC5_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl+ytnsPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqKq7MP/i626gBZv+jty268LRYFOSuPa54zBUrO5NMl
m9zWZwzX7mtL524gdverS0KXCOty5z6dHWvJH+F+VkcmUpYcJKb3hYeEiOySkNmE
DyxP9OE1keGx2kMkX0yXyn7KAsq7uRTeVkrEbrsLHlI6KMi8CMnTPeCdwkmXb3DO
zs+jZbk+SsGySbW9u3DIlUzqMK2dShT+97btwA7PTciD1eJajrDTM+9CKxLWf7Ni
kugBl4T+mWU7/BqX/wNtGJQGQa1XHNkcl4eX4rePouvSKjtMNKqWkvtgZY2VCbPd
dvzo46p4W3QAKH2pspwSK0twGGwpZ288VZZcrdp/9btPAkJyyRzXOLlH0K66w82n
CSEwM1vcGMSY77PZCGPMtcLvJMSFgfIEt4hgGRF8Mu6X4IMGLeC5+XcrvxWovfEI
gRcHO12jlKX32dH/1a76UUYY9KGo611RkEoMPmBEITfUiNTweGpMzuvvvQMSmFxU
+Ox2DpSfpv+HeoGVjfopOBUHRYNI43fNYY0qW+k+PhcMVxP5yE8VD/+a7R/bESNX
jMq5UaG7xHFlOGfQwMU5LIJV37L1/M+5CbhqdJ958afd0ds+oyqgfzYu3cjJdu7h
BeobbjDzll9ATm7s6Wwf+vPw9K2QcnaEzdAuAAZiZMH8Z/lYZrZxlssNL62a2Mrv
/kIkI2ho
=BS+b
-----END PGP SIGNATURE-----

--=_MailMate_F877A42F-87E8-4D50-BD05-6C2E64926FC5_=--