Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3390261pxb; Mon, 16 Nov 2020 13:21:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiIBEwpuBzFs3GzBts8NwO5ylBOq4Dc4EDh4lRZnx8kr7OjUakc8ZnyDz3zCGnwvd1qrkt X-Received: by 2002:a50:ec10:: with SMTP id g16mr18165445edr.63.1605561710798; Mon, 16 Nov 2020 13:21:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605561710; cv=none; d=google.com; s=arc-20160816; b=1EiUsx3+EVieeTMpBUGv07LtEf2EkWwMndB++j+YG01/9xEecfhfGTVbbnF7gZTgtD yWGOGafUVj3XlyYdhMRRR98vF7FH3FrNJkFjWq68y5yILUObFpmJFOIEW8GWcnT0PlQ/ DDAoudkKwb8Ez/5w3QfRZTAyXvuGVmEZRfmpsWnUMCpCVQ0FidsEA0EnTZa+GILbT2PE DAc7n1YdCIZ36ZZrKY0Ur1wuQIkR5ro/8qV9w5VDey0lJEXxEm/Mo6WnWK8100H9Vbgm 1MiAsFyX+CT/TleL0AV+gkMukXo5VWtGbkdqPvy5Wb88IKyDgu6A1jBbfNjW/iuoPOSH CDMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YQbOeR0Ir0jO5GxTkZ/KPEcLOqI6KXbHLyISKeSbQ2k=; b=TCuz4//vM6XVJtUQXA2Tbfw+giGCLK8sCEGEaP3OdGkh9WACSHtmFcZLdras3NuQTF Lmv8eM9H0HRnsEI96J5r2qMrcNJf/YZA7/SiJld+0uMLaNYVhMhV9ndGawB1wRSdAHOh rO0E9oeCZVrRozS0HydJiNodIE90sPyY4EFxSJhbHVdfZSWF3xF1M3HWBxv+RSlayV8/ zCyx8RZ5zHPzQb1N8HJA//WdgNGmswu3WY75Pzh3Zr/64uqHPCZEC5jk55OP3MaARfri dk/n1z+jFeJLdgqwv1NMPimDp5oMpB5dduobxTfNRJz+u9rGr5XP8vQMhvpiF+0uZB2s EgsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f3nHWDB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si12188972ejc.124.2020.11.16.13.21.27; Mon, 16 Nov 2020 13:21:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f3nHWDB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728164AbgKPTEU (ORCPT + 99 others); Mon, 16 Nov 2020 14:04:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:53580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgKPTEU (ORCPT ); Mon, 16 Nov 2020 14:04:20 -0500 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52B132225B; Mon, 16 Nov 2020 19:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605553459; bh=YQbOeR0Ir0jO5GxTkZ/KPEcLOqI6KXbHLyISKeSbQ2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3nHWDB5UYIanun4/6bqobOCfJotTUjTtZItEmpy0wO6KaXjrxdusbSMS4ljgIs1V pDbRIw4hq7DjsHI/TtpuMdrR/of84ih03VU/ZohdCYYh2vZ8V+NmW9wOj8Dsj2ZgmL OKSRtmDgMyutH1MzfMyRjnQs3SXIohzYYhKlIbjs= Date: Mon, 16 Nov 2020 19:04:00 +0000 From: Mark Brown To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , V Sujith Kumar Reddy Subject: Re: [PATCH] Asoc: qcom: lpass-platform: Fix memory leak Message-ID: <20201116190400.GE4739@sirena.org.uk> References: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz" Content-Disposition: inline In-Reply-To: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> X-Cookie: Immanuel doesn't pun, he Kant. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --brEuL7wsLY8+TuWz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 10:26:50AM +0530, Srinivasa Rao Mandadapu wrote: > lpass_pcm_data is not freed in error paths. Free it in > error paths to avoid memory leak. Please use subject lines reflecting the general style for the subsystem, it makes it easier for people to spot patches that need to be reviewed. --brEuL7wsLY8+TuWz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+yzSAACgkQJNaLcl1U h9CULgf/enozSv/x01jexTc5wfCzv9oWXsElA/pDZMQvwp2/Hix6fWeuOPzmWIo7 7PYUVqp5i6mJWejVH+qDpIVIwo2V/KzyT81D5JmooPoOglEZzKdiJcj0LK7mkkD+ T21T3qhVwaWml3gna9W8srBFidN3/gJ7+Agd5M3nQbxGtqINtMPBrJ1y7F6CsGhc +pTCkwcpDe/oOhWiV/iifsBhWYmkdCWHypN3vMSDMzuiE5u+PcnZchGhPSdCqrJF FXZ0dMoESRKqUS+MoVa0o3tAL6SEnY/gXvmFEJAw7bYCfpID82GULtwfDuuFmApK qXYtPZY8/noF2WY+pdHO582yoJ12ag== =NfJ5 -----END PGP SIGNATURE----- --brEuL7wsLY8+TuWz--