Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 16 Nov 2020 13:28:01 -0600
From:   Rob Herring <robh@kernel.org>
To:     Wenbin Mei <wenbin.mei@mediatek.com>
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        irq-linux@rere.qmqm.pl,
        Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Baolin Wang <baolin.wang@linaro.org>,
        Ludovic Barre <ludovic.barre@st.com>,
        Krishna Konda <kkonda@codeaurora.org>,
        Bradley Bolen <bradleybolen@gmail.com>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add optional cqe off properties
Message-ID: <20201116192801.GA1991505@bogus>
References: <20201112075208.28183-1-wenbin.mei@mediatek.com>
 <20201112075208.28183-2-wenbin.mei@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112075208.28183-2-wenbin.mei@mediatek.com>
Precedence: bulk

On Thu, Nov 12, 2020 at 03:52:06PM +0800, Wenbin Mei wrote:
> Add optional properties for cqe hosts which are used to set cqe off
> during suspend flow.
> 
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index b96da0c7f819..457c9a84b988 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -164,6 +164,13 @@ properties:
>      description:
>        enable SDIO IRQ signalling on this interface
>  
> +  cqe-off-in-suspend:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      After suspend, the mmc host is powered off by HW, and bring CQE register
> +      to default state, so we add the flag to re-init CQE register after resume
> +      back.

The driver change is before suspend, but this says on resume...

In any case, this should be implied by the SoC specific compatible.

> +
>    full-pwr-cycle:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.18.0
>